refactor: update AutoTriggerStrategy.getPrompts API to accept AutocompleteInput #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markijbema
commented
Oct 21, 2025
| } | ||
|
|
||
| // Add current position | ||
| if (context.range && context.document) { |
There was a problem hiding this comment.
it removes these ifs, but i do not think they were ever necessary tbh
markijbema
commented
Oct 21, 2025
| return false | ||
| } | ||
|
|
||
| export function extractComment(document: TextDocument, currentLine: number): string { |
There was a problem hiding this comment.
unrelated, but when i removed use of another import of autotrigger strategy i noticed this was unused as well
…pleteInput Changed the getPrompts method signature to align with autocomplete system architecture: - Now accepts AutocompleteInput, prefix, suffix, and languageId as separate parameters - Made GhostSuggestionContext optional since data is provided through other params - Updated all callers in GhostProvider, tests, and utilities This change extracts parts from PR #3102 to make the API more flexible and better aligned with the autocomplete input structure used throughout the system. Modified files: - src/services/ghost/strategies/AutoTriggerStrategy.ts - src/services/ghost/GhostProvider.ts - src/services/ghost/strategies/__tests__/AutoTriggerStrategy.test.ts - src/services/ghost/__tests__/GhostRecentOperations.spec.ts - src/services/ghost/__tests__/GhostModelPerformance.spec.ts - src/test-llm-autocompletion/strategy-tester.ts All tests passing (28/28)
Now the getPrompts methods actually use the AutocompleteInput parameter: - getUserPrompt uses autocompleteInput.recentlyEditedRanges and autocompleteInput.pos - getCommentsUserPrompt extracts comment from prefix instead of context.document - Both methods build code with cursor from prefix/suffix instead of document - Updated test to properly populate AutocompleteInput.recentlyEditedRanges This completes the refactoring to make the API truly independent of GhostSuggestionContext, using the autocomplete input structure instead.
…tPrompts() - Removed unused context?: GhostSuggestionContext parameter from getPrompts method - Updated all callsites in GhostProvider and test files - All tests passing (28 tests across 3 test files)
…lication - Replace manual AutocompleteInput conversion in GhostProvider with contextToAutocompleteInput helper - Update GhostRecentOperations test to use the helper function - Reduces ~30 lines of duplicated conversion logic - All 208 ghost service tests pass
markijbema
force-pushed
the
mark/autotrigger-api
branch
from
53547b4 to
e1a89c2
Compare
EamonNerbonne
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the getPrompts method signature to align with autocomplete system architecture:
This change extracts parts from PR #3102 to make the API more flexible and better aligned with the autocomplete input structure used throughout the system.