-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial support for Fireworks provider #16
Conversation
It's only supporting deepseek-v3 and deepseek-r1. I tried to follow former Provider implementations If you need a Fireworks key to test this, ping me on slack :) |
@@ -0,0 +1,786 @@ | |||
// npx jest src/api/providers/__tests__/fireworks.test.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked too deeply yet, but why is this file so much longer than most of the other tests in /src/api/providers/__tests__
? Just wondering if there are some unnecessary tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No one has ever claimed to have enough tests... but Kilocode helped me with this 😉. I also borrowed some inspiration from other implementations, but there are a few special cases, such as the </thinking>
tokens from DeepSeek's models in the response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me know, aside from some git hygiene. I'll let @kevinvandijk also have a look, and maybe he can show you how to do better git hygiene, because he's good at that. Overall, nice, let's ship this soon!
I also moved the Fireworks code to be close the Kilocode provider
Adds support for the Fireworks AI platform as a new provider option, specifically integrating the
deepseek-r1
model via the Fireworks. This addition expands our available providers options, giving users access to more powerful reasoning capabilities, particularly with DeepSeek's large context window of 160k tokens, but faster with Fireworks.The implementation follows existing provider architecture pattern while adding Fireworks-specific adaptations:
The implementation uses the OpenAI compatible library with Fireworks.