refactor: CI workflow improvements for Kilo #221
Conversation
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
.github/workflows/beta.yml
Outdated
| # (github.event_name == 'pull_request' && | ||
| # contains(github.event.pull_request.labels.*.name, 'contributor')) | ||
| # kilocode_change end | ||
| if: | |
There was a problem hiding this comment.
WARNING: sync job if condition can never be true for this workflow’s triggers
This workflow only runs on workflow_dispatch and schedule, but the job condition checks for push or pull_request. As written, sync will always be skipped (including on the hourly cron). Consider removing the condition or updating it to include schedule/workflow_dispatch.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (20 files)
|
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
| app-id: ${{ inputs.opencode-app-id }} | ||
| private-key: ${{ inputs.opencode-app-secret }} | ||
| # kilocode_change start | ||
| app-id: ${{ inputs.kilo-maintainer-app-id }} |
There was a problem hiding this comment.
CRITICAL: Hyphenated inputs key must use bracket notation
GitHub Actions expressions treat - as subtraction in dot-notation (e.g. inputs.kilo-maintainer-app-id), which can break expression parsing and prevent the app token from being created. Use bracket notation for hyphenated keys.
| app-id: ${{ inputs.kilo-maintainer-app-id }} | |
| app-id: ${{ inputs['kilo-maintainer-app-id'] }} |
| private-key: ${{ inputs.opencode-app-secret }} | ||
| # kilocode_change start | ||
| app-id: ${{ inputs.kilo-maintainer-app-id }} | ||
| private-key: ${{ inputs.kilo-maintainer-app-secret }} |
There was a problem hiding this comment.
CRITICAL: Hyphenated inputs key must use bracket notation
Same parsing issue as the app-id line above; this can cause private-key to be empty and actions/create-github-app-token@v2 to fail.
| private-key: ${{ inputs.kilo-maintainer-app-secret }} | |
| private-key: ${{ inputs['kilo-maintainer-app-secret'] }} |
| outputs: | ||
| is-member: | ||
| description: Whether the user is an org member or kilo-maintainer bot | ||
| value: ${{ jobs.check.outputs.is-member }} |
There was a problem hiding this comment.
CRITICAL: Hyphenated output key should use bracket notation
${{ jobs.check.outputs.is-member }} is likely to be parsed as subtraction (outputs.is - member). Use bracket notation when referencing outputs that contain hyphens.
| value: ${{ jobs.check.outputs.is-member }} | |
| value: ${{ jobs.check.outputs['is-member'] }} |
2 participants
Summary
Changes
Workflow improvements
beta.ymlworkflow with Kilo credentialsgenerate.ymlworkflow with Kilo credentialscontainers.ymlworkflow for building container imagespr-management.ymlwith proper Kilo API integrationpr-standards.ymlto use org membership checkNew features
check-org-member.ymlreusable workflow for checking if user is org member or kilo-maintainer botsetup-kiloGitHub Action to install Kilo CLI globallyConfiguration updates
setup-git-committeraction to use kilo-maintainer credentialssetup-bunaction to use OS-specific cache keysghcr.io/anomalycotoghcr.io/Kilo-OrgAll changes are marked with
kilocode_changecomments for easy tracking during upstream merges.