Re-enable mempool

[Thaleszh]

Description

Enables mempool again after fork fixes

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pipelines

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Walkthrough

Re-enables the EVM mempool by calling the mempool configuration during app initialization when a chain config exists. Removes clientCtx from the NewExperimentalEVMMempool invocation and drops a nolint:unused annotation. Restores and enables EVM mempool e2e tests and re-adds the test invocation in the test suite. Sets appConfig.Mempool.MaxTxs = 0 in e2e setup and updates contrib/local_node.sh to set max-txs = 0 when enabling metrics. Splits a changelog entry into three fixed items and updates a go.mod replace from v0.5.1-fork.2 to v0.5.1-fork.3.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Re-enable mempool' directly and concisely summarizes the main objective of the changeset across all modified files.
Description check	✅ Passed	The description is related to the changeset, explaining that the PR enables mempool after fork fixes, which aligns with the actual changes made.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/enable-mempool

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@app/app.go`:
- Around line 276-278: The EVM mempool constructor (NewExperimentalEVMMempool)
used inside configureEVMMempool can fail and its return must be validated;
update configureEVMMempool to check the mempool value returned by
NewExperimentalEVMMempool (and any error it returns) and handle failures
gracefully (e.g., log the error via logger/processLogger and abort startup or
return the error to the caller) instead of proceeding with a nil/invalid
mempool; specifically add a nil check after the NewExperimentalEVMMempool call
in configureEVMMempool and propagate or handle the error so app startup (the
call site configureEVMMempool in app.go) never attempts to use an invalid
mempool.

🧹 Nitpick comments (1)

tests/e2e/e2e_evm_test.go (1)

137-137: Consider using a more robust synchronization mechanism.

The 500ms sleep is used to ensure transaction ordering, but hardcoded sleeps can cause test flakiness in CI environments with varying loads. Consider either:

1. Increasing the sleep duration with a comment explaining why, or
2. Adding a retry/polling mechanism to verify the transaction is in the mempool before sending the next one.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@go.mod`:
- Around line 313-315: The go.mod entry replacing github.com/cosmos/evm with
github.com/KiiChain/evm v0.5.1-fork.3 must be verified reachable before merging:
confirm the forked module and tag v0.5.1-fork.3 exist and are accessible from
CI/build environment (or make the repo reachable via GOPRIVATE/GONOSUMDB or by
adding a proper git URL); if it is private, update build config
(GOPRIVATE/GONOSUMDB or go env git credentials) or replace the module with a
local path or vendored copy instead of the unreachable version; locate and
update the go.mod replacement line referencing github.com/KiiChain/evm and
v0.5.1-fork.3 accordingly.