Open
Conversation
Author
|
@KieronQuinn feel free to req changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
This change is intended to improve the Smartspacer experience on more devices. Since not all OEMs support Native Smartspace (e.g. Samsung, Xiaomi, Huawei, users on these devices can not scroll through targets, instead having to enable button-based navigation.
Implementation
All that said, some OEMs do support stackable widgets. This change lets users pin individual targets to widget instances, letting them stack multiple instances and scroll through those. There is the obvious downside that users will lose the seamless experience of having targets take priority by themselves. For those who want to let Smartspacer use its existing logic for target sorting, you can also just pin widget instances to page numbers, letting the app dynamically prioritize targets to display.