Repository navigation
spirv-opt: Add constant folding for more GLSL.std.450 extended instructions - #6983
Open
juliusikkala wants to merge 5 commits into
Open
juliusikkala wants to merge 5 commits into
juliusikkala wants to merge 5 commits into
Conversation
Sinh, Cosh, Tanh, Asinh, Acosh, Atanh and InverseSqrt.
juliusikkala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes constant folding for the following GLSL.std.450 extended instructions: Sinh, Cosh, Tanh, Asinh, Acosh, Atanh, InverseSqrt, Round, Trunc, Floor, Ceil, Fract, FSign, SSign, Radians, Degrees, Step, SmoothStep and Fma. This subset is included mostly because constant folding is fairly trivial to implement for them.
To handle Fma and SmoothStep, there's now
TernaryScalarFoldingRule,FoldTernaryOpandFoldFPTernaryOp. Their implementation is mostly copypasta from the binary equivalents. I also renamedFoldFTranscendentalUnarytoFoldUnaryFloatingPointOperationbecause nothing about it is specific to transcendental functions and this naming is more in line with the already existingFoldUnaryIntegerOperation.Works towards fixing #6981 but does not implement all of it.