[BetterCrafting] Also set CraftingRecipe field (if possible) for SpaceCore recipes (fix YACS integration)#34
Open
zombifier wants to merge 1 commit intoKhloeLeclair:mainfrom
Conversation
zombifier
changed the title
zombifier
added a commit
to zombifier/Pet-Slime_StardewValley
that referenced
this pull request
Aug 31, 2024
The fix on BetterCrafting side: KhloeLeclair/StardewMods#34
|
While this fixes an issue with YACS, I would like to also point out it will fix an issue with any mod that uses bettercrafting and looks for the CraftingRecipe field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the field to the vanilla equivalent if possible.
This fixes Yet Another Cooking Skill's integration with SpaceCore recipes added by Better Crafting. YACS was expecting this field to be set, which it is for vanilla recipes but not SC ones (code snippet).
Also sneaked in changes to
Common.projitemsto make this mod build on Linux's case sensitive file system. Please let me know if I should take it out.