20250205/Login-Loading-UI-with-Nextjs/ 심정아 기술블로그 제출 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanShim
requested review from
day1companyhaewooklee and
day1chan99k
as code owners
hjh010501
reviewed
Feb 8, 2025
| @@ -0,0 +1,110 @@ | |||
| --- | |||
| layout: post | |||
| title: "Next.js 로그인 로딩 ui를 만들어보자 (useState, react-hook-form, server action)" | |||
There was a problem hiding this comment.
로딩 UI 랑 동시에 Form 에러 핸들링 부분도 포함해서 보여주시는건 어떠실지요?
로딩은 워낙 콘텐츠 내용이 적기도 하고, 에러 핸들링을 하는 부분 (zod 로 데이터 체크 / 로그인 실패 시 어떻게 할지 등등) 도 추가하면 더 양질의 내용을 추가하고, "유저경험" 이라는 관점으로 더 글을 확장시켜 볼 수 있을 것 같습니다.
| } | ||
| ``` | ||
|
|
||
| ### 3. server action과 useFormStatus |
There was a problem hiding this comment.
3번이랑 2번의 차이를 3번을 종결할 때 적어주시는 것도 좋을 것 같고, 2번의 장/단점이 있어야 3번이 조금 더 설득력 있을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.