Add Bonus-Bericht export for formatted payroll reports#21
Merged
Conversation
- Added new "Bonus-Bericht" button to both Dienstplan_Portable.html and webapp - Creates a printable HTML report with: - Header with "Bonuszahlungen" title - Month and payout date information - Table showing duties per weekday with amounts per employee - Individual explanatory notes for each employee - Print/PDF save button - Format matches user's requested output style from issue #20 Co-authored-by: Kenearos <86194771+Kenearos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add output file structure for HTML document
Add Bonus-Bericht export for formatted payroll reports
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new "Bonus-Bericht" (Bonus Report) export feature that generates formatted HTML payroll reports suitable for printing or saving as PDF. The report presents duty rosters in a weekday-based table format with per-employee bonus calculations and detailed explanations.
Key Changes:
- New
exportBonusReport()function added to both webapp and portable versions - HTML report generation with professional styling and print support
- New UI button "📝 Bonus-Bericht" added to Data/Settings tabs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| webapp/index.html | Added "Bonus-Bericht" button and updated tooltip text to inform users about the new report feature |
| webapp/app.js | Implemented exportBonusReport() function (~310 lines) that generates HTML reports with duty tables, bonus calculations, and employee-specific explanations |
| Dienstplan_Portable.html | Implemented exportBonusReport() function (~310 lines) mirroring the webapp version with same functionality for the standalone version |
Comments suppressed due to low confidence (3)
webapp/app.js:552
- Unused variable weekdays.
const weekdays = ['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag'];
webapp/app.js:792
- Unused variable dateStr.
const dateStr = duty.date.getDate() + '.';
Dienstplan_Portable.html:1331
- Unused variable dateStr.
const dateStr = duty.date.getDate() + '.';
Comment on lines
+765
to
+839
| note += `Erreicht das Bonussystem nicht (nur ${we_total.toFixed(1)} WE-Einheiten, mind. 2,0 erforderlich).`; | ||
| } else { | ||
| const details = []; | ||
| if (data.wt > 0) details.push(`${data.wt.toFixed(1)} WT × 250€`); | ||
| if (data.we_fr > 0 || data.we_other > 0) { | ||
| const paid_we = we_total - 1.0; | ||
| details.push(`${paid_we.toFixed(1)} WE × 450€ (abzgl. 1,0 Abzug von ${deductedFrom})`); | ||
| } | ||
| note += `Erhält ${this.calculator.formatCurrency(bonus)}. ${details.join(', ')}.`; | ||
| } | ||
| employeeNotes.push(note); | ||
|
|
||
| // Build table row | ||
| html += ` | ||
| <tr> | ||
| <td class="employee-name">${safeName}</td>`; | ||
|
|
||
| // Days: Mo(1), Di(2), Mi(3), Do(4), Fr(5), Sa(6), So(0) | ||
| const dayOrder = [1, 2, 3, 4, 5, 6, 0]; | ||
|
|
||
| for (const dayIdx of dayOrder) { | ||
| const dayDuties = data.byWeekday[dayIdx]; | ||
| if (dayDuties.length === 0) { | ||
| html += `<td></td>`; | ||
| } else { | ||
| let cellContent = ''; | ||
| dayDuties.forEach(duty => { | ||
| const dateStr = duty.date.getDate() + '.'; | ||
| const shareStr = duty.share === 0.5 ? '½' : ''; | ||
| const amountStr = duty.isQual ? `${Math.round(duty.share * this.calculator.RATE_WEEKEND)}€` : `${Math.round(duty.share * this.calculator.RATE_NORMAL)}€`; | ||
| const tag = duty.isQual ? 'we-tag' : 'wt-tag'; | ||
| const isHoliday = this.holidayProvider.isHoliday(duty.date); | ||
| const isDayBefore = this.holidayProvider.isDayBeforeHoliday(duty.date); | ||
| const extraInfo = isHoliday ? ' (Feiertag)' : isDayBefore ? ' (Vor Feiertag)' : ''; | ||
|
|
||
| cellContent += `<span class="${tag}">${shareStr}X${extraInfo}</span><br><small>${amountStr}</small><br>`; | ||
| }); | ||
| html += `<td class="duty-cell">${cellContent}</td>`; | ||
| } | ||
| } | ||
|
|
||
| html += ` | ||
| <td class="${bonus > 0 ? 'bonus-amount' : 'no-bonus'}">${bonus > 0 ? this.calculator.formatCurrency(bonus) : '-'}</td> | ||
| </tr>`; | ||
| } | ||
|
|
||
| html += ` | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <div class="summary"> | ||
| <p class="total">Gesamtsumme: ${this.calculator.formatCurrency(totalBonus)}</p> | ||
| </div> | ||
|
|
||
| <h4>Erläuterungen zu den einzelnen Mitarbeitern:</h4> | ||
| `; | ||
|
|
||
| employeeNotes.forEach(note => { | ||
| html += `<div class="employee-note">${note}</div>\n`; | ||
| }); | ||
|
|
||
| html += ` | ||
| <div style="margin-top: 40px; padding-top: 20px; border-top: 1px solid #ddd;"> | ||
| <p><strong>Berechnungsregeln (Variante 2 - Streng):</strong></p> | ||
| <ul> | ||
| <li><strong>WE-Tage:</strong> Freitag, Samstag, Sonntag, Feiertage und Tage vor Feiertagen</li> | ||
| <li><strong>Schwelle:</strong> Mindestens 2,0 WE-Einheiten für Bonuszahlung erforderlich</li> | ||
| <li><strong>Vergütung bei Erreichen der Schwelle:</strong> | ||
| <ul> | ||
| <li>Werktage (WT): 250 € pro Einheit</li> | ||
| <li>WE-Tage: 450 € pro Einheit (abzüglich 1,0 Einheit Abzug, Freitag zuerst)</li> | ||
| </ul> | ||
| </li> | ||
| <li><strong>Unter Schwelle:</strong> Keine Bonuszahlung (weder WT noch WE)</li> | ||
| </ul> |
There was a problem hiding this comment.
Hardcoded rate values (250€, 450€, 2,0, 1,0) in the employee notes and rules section should use the calculator's constants (RATE_NORMAL, RATE_WEEKEND, MIN_QUALIFYING_DAYS) to maintain consistency. If these rates are changed in the calculator, the report text will become inaccurate.
Comment on lines
+1304
to
+1377
| note += `Erreicht das Bonussystem nicht (nur ${we_total.toFixed(1)} WE-Einheiten, mind. 2,0 erforderlich).`; | ||
| } else { | ||
| const details = []; | ||
| if (data.wt > 0) details.push(`${data.wt.toFixed(1)} WT × 250€`); | ||
| if (data.we_fr > 0 || data.we_other > 0) { | ||
| const paid_we = we_total - 1.0; | ||
| details.push(`${paid_we.toFixed(1)} WE × 450€ (abzgl. 1,0 Abzug von ${deductedFrom})`); | ||
| } | ||
| note += `Erhält ${this.formatCurrency(bonus)}. ${details.join(', ')}.`; | ||
| } | ||
| employeeNotes.push(note); | ||
|
|
||
| // Build table row | ||
| html += ` | ||
| <tr> | ||
| <td class="employee-name">${safeName}</td>`; | ||
|
|
||
| // Days: Mo(1), Di(2), Mi(3), Do(4), Fr(5), Sa(6), So(0) | ||
| const dayOrder = [1, 2, 3, 4, 5, 6, 0]; | ||
|
|
||
| for (const dayIdx of dayOrder) { | ||
| const dayDuties = data.byWeekday[dayIdx]; | ||
| if (dayDuties.length === 0) { | ||
| html += `<td></td>`; | ||
| } else { | ||
| let cellContent = ''; | ||
| dayDuties.forEach(duty => { | ||
| const dateStr = duty.date.getDate() + '.'; | ||
| const shareStr = duty.share === 0.5 ? '½' : ''; | ||
| const amountStr = duty.isQual ? `${Math.round(duty.share * CONFIG.RATE_WE)}€` : `${Math.round(duty.share * CONFIG.RATE_WT)}€`; | ||
| const tag = duty.isQual ? 'we-tag' : 'wt-tag'; | ||
| const extraInfo = duty.dayInfo.type === 'holiday' ? ' (Feiertag)' : | ||
| duty.dayInfo.type === 'preHoliday' ? ' (Vor Feiertag)' : ''; | ||
|
|
||
| cellContent += `<span class="${tag}">${shareStr}X${extraInfo}</span><br><small>${amountStr}</small><br>`; | ||
| }); | ||
| html += `<td class="duty-cell">${cellContent}</td>`; | ||
| } | ||
| } | ||
|
|
||
| html += ` | ||
| <td class="${bonus > 0 ? 'bonus-amount' : 'no-bonus'}">${bonus > 0 ? this.formatCurrency(bonus) : '-'}</td> | ||
| </tr>`; | ||
| } | ||
|
|
||
| html += ` | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <div class="summary"> | ||
| <p class="total">Gesamtsumme: ${this.formatCurrency(totalBonus)}</p> | ||
| </div> | ||
|
|
||
| <h4>Erläuterungen zu den einzelnen Mitarbeitern:</h4> | ||
| `; | ||
|
|
||
| employeeNotes.forEach(note => { | ||
| html += `<div class="employee-note">${note}</div>\n`; | ||
| }); | ||
|
|
||
| html += ` | ||
| <div style="margin-top: 40px; padding-top: 20px; border-top: 1px solid #ddd;"> | ||
| <p><strong>Berechnungsregeln (Variante 2 - Streng):</strong></p> | ||
| <ul> | ||
| <li><strong>WE-Tage:</strong> Freitag, Samstag, Sonntag, Feiertage und Tage vor Feiertagen</li> | ||
| <li><strong>Schwelle:</strong> Mindestens 2,0 WE-Einheiten für Bonuszahlung erforderlich</li> | ||
| <li><strong>Vergütung bei Erreichen der Schwelle:</strong> | ||
| <ul> | ||
| <li>Werktage (WT): 250 € pro Einheit</li> | ||
| <li>WE-Tage: 450 € pro Einheit (abzüglich 1,0 Einheit Abzug, Freitag zuerst)</li> | ||
| </ul> | ||
| </li> | ||
| <li><strong>Unter Schwelle:</strong> Keine Bonuszahlung (weder WT noch WE)</li> | ||
| </ul> |
There was a problem hiding this comment.
Hardcoded rate values (250€, 450€, 2,0, 1,0) in the employee notes and rules section should use CONFIG constants (RATE_WT, RATE_WE, THRESHOLD, DEDUCTION) to maintain consistency. If these rates are changed in CONFIG, the report text will become inaccurate.
Comment on lines
+549
to
+858
| exportBonusReport() { | ||
| const monthNames = ['Januar', 'Februar', 'März', 'April', 'Mai', 'Juni', | ||
| 'Juli', 'August', 'September', 'Oktober', 'November', 'Dezember']; | ||
| const weekdays = ['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag']; | ||
|
|
||
| const month = parseInt(document.getElementById('calc-month-select').value); | ||
| const year = parseInt(document.getElementById('calc-year-select').value); | ||
|
|
||
| // Calculate next month for payout date | ||
| const payoutMonth = month % 12; | ||
| const payoutYear = month === 12 ? year + 1 : year; | ||
|
|
||
| const employeeDuties = this.storage.getAllEmployeeDutiesForMonth(year, month); | ||
| const employees = Object.keys(employeeDuties); | ||
|
|
||
| if (employees.length === 0) { | ||
| this.showToast('Keine Dienste für diesen Monat vorhanden.', 'error'); | ||
| return; | ||
| } | ||
|
|
||
| // Escape HTML function | ||
| const escapeHtml = (str) => { | ||
| return String(str).replace(/[&<>"']/g, c => ({ | ||
| '&': '&', '<': '<', '>': '>', '"': '"', "'": ''' | ||
| }[c])); | ||
| }; | ||
|
|
||
| // Group duties by employee and weekday | ||
| const employeeData = {}; | ||
| for (const [name, duties] of Object.entries(employeeDuties)) { | ||
| employeeData[name] = { | ||
| duties: duties, | ||
| byWeekday: { 0: [], 1: [], 2: [], 3: [], 4: [], 5: [], 6: [] }, | ||
| wt: 0, | ||
| we_fr: 0, | ||
| we_other: 0 | ||
| }; | ||
|
|
||
| duties.forEach(duty => { | ||
| const dayOfWeek = duty.date.getDay(); | ||
| const isQualifying = this.calculator.isQualifyingDay(duty.date); | ||
| const isFriday = dayOfWeek === 5; | ||
|
|
||
| employeeData[name].byWeekday[dayOfWeek].push({ | ||
| ...duty, | ||
| isQual: isQualifying, | ||
| dayType: this.calculator.getDayTypeLabel(duty.date) | ||
| }); | ||
|
|
||
| if (!isQualifying) { | ||
| employeeData[name].wt += duty.share; | ||
| } else if (isFriday) { | ||
| employeeData[name].we_fr += duty.share; | ||
| } else { | ||
| employeeData[name].we_other += duty.share; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| // Build HTML report | ||
| let html = `<!DOCTYPE html> | ||
| <html lang="de"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>Bonuszahlungen ${monthNames[month - 1]} ${year}</title> | ||
| <style> | ||
| body { | ||
| font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif; | ||
| margin: 40px; | ||
| color: #333; | ||
| line-height: 1.6; | ||
| } | ||
| h3 { | ||
| color: #4472C4; | ||
| border-bottom: 2px solid #4472C4; | ||
| padding-bottom: 10px; | ||
| } | ||
| h5 { | ||
| color: #666; | ||
| margin-bottom: 20px; | ||
| } | ||
| table { | ||
| border-collapse: collapse; | ||
| width: 100%; | ||
| margin: 20px 0; | ||
| } | ||
| th, td { | ||
| border: 1px solid #ddd; | ||
| padding: 10px 8px; | ||
| text-align: center; | ||
| } | ||
| th { | ||
| background-color: #4472C4; | ||
| color: white; | ||
| font-weight: bold; | ||
| } | ||
| tr:nth-child(even) { | ||
| background-color: #f9f9f9; | ||
| } | ||
| .employee-name { | ||
| text-align: left; | ||
| font-weight: bold; | ||
| } | ||
| .bonus-amount { | ||
| font-weight: bold; | ||
| color: #28a745; | ||
| } | ||
| .no-bonus { | ||
| color: #dc3545; | ||
| } | ||
| .duty-cell { | ||
| font-size: 0.85em; | ||
| } | ||
| .duty-cell .we-tag { | ||
| background: #d4edda; | ||
| color: #155724; | ||
| padding: 2px 6px; | ||
| border-radius: 3px; | ||
| font-size: 0.9em; | ||
| } | ||
| .duty-cell .wt-tag { | ||
| background: #e7e7e7; | ||
| color: #666; | ||
| padding: 2px 6px; | ||
| border-radius: 3px; | ||
| font-size: 0.9em; | ||
| } | ||
| .employee-note { | ||
| margin: 10px 0; | ||
| padding: 10px; | ||
| background: #f8f9fa; | ||
| border-left: 3px solid #4472C4; | ||
| } | ||
| .employee-note b { | ||
| color: #4472C4; | ||
| } | ||
| .summary { | ||
| margin-top: 30px; | ||
| padding: 20px; | ||
| background: #e7f3ff; | ||
| border-radius: 8px; | ||
| } | ||
| .total { | ||
| font-size: 1.2em; | ||
| font-weight: bold; | ||
| color: #4472C4; | ||
| } | ||
| @media print { | ||
| body { margin: 20px; } | ||
| .no-print { display: none; } | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <div class="no-print" style="margin-bottom: 20px; padding: 10px; background: #fff3cd; border-radius: 5px;"> | ||
| <button onclick="window.print()" style="padding: 8px 16px; background: #4472C4; color: white; border: none; border-radius: 4px; cursor: pointer; margin-right: 10px;">🖨️ Drucken / Als PDF speichern</button> | ||
| <span style="color: #666;">Tipp: Beim Drucken "Als PDF speichern" wählen für eine PDF-Datei.</span> | ||
| </div> | ||
|
|
||
| <h3>Bonuszahlungen</h3> | ||
| <h5>Monat ${monthNames[month - 1]} ${year} mit Auszahlung Ende ${monthNames[payoutMonth]} ${payoutYear}</h5> | ||
|
|
||
| <p>Für die im ${monthNames[month - 1]} ${year} geleisteten Bereitschaftsdienste ergeben sich folgende Bonuszahlungen:</p> | ||
|
|
||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>Mitarbeiter</th> | ||
| <th>Mo</th> | ||
| <th>Di</th> | ||
| <th>Mi</th> | ||
| <th>Do</th> | ||
| <th>Fr</th> | ||
| <th>Sa</th> | ||
| <th>So</th> | ||
| <th>Bonus (€)</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody>`; | ||
|
|
||
| let totalBonus = 0; | ||
| const employeeNotes = []; | ||
|
|
||
| for (const [name, data] of Object.entries(employeeData)) { | ||
| const we_total = data.we_fr + data.we_other; | ||
| const thresholdReached = we_total >= this.calculator.MIN_QUALIFYING_DAYS - 0.0001; | ||
|
|
||
| let bonus = 0; | ||
| let deductedFrom = ''; | ||
|
|
||
| if (thresholdReached) { | ||
| const wt_pay = data.wt * this.calculator.RATE_NORMAL; | ||
| let deduct = 1.0; | ||
| const deduct_fr = Math.min(deduct, data.we_fr); | ||
| const deduct_other = Math.max(0, deduct - deduct_fr); | ||
| const paid_fr = Math.max(0, data.we_fr - deduct_fr); | ||
| const paid_other = Math.max(0, data.we_other - deduct_other); | ||
| const we_pay = (paid_fr + paid_other) * this.calculator.RATE_WEEKEND; | ||
| bonus = wt_pay + we_pay; | ||
|
|
||
| if (deduct_fr > 0 && deduct_other > 0) { | ||
| deductedFrom = 'Freitag und weiterer WE-Tag'; | ||
| } else if (deduct_fr > 0) { | ||
| deductedFrom = 'Freitag'; | ||
| } else { | ||
| deductedFrom = 'WE-Tag (Sa/So/Feiertag)'; | ||
| } | ||
| } | ||
|
|
||
| totalBonus += bonus; | ||
|
|
||
| // Generate note | ||
| const safeName = escapeHtml(name); | ||
| let note = `<b>${safeName}</b>: `; | ||
|
|
||
| if (!thresholdReached) { | ||
| note += `Erreicht das Bonussystem nicht (nur ${we_total.toFixed(1)} WE-Einheiten, mind. 2,0 erforderlich).`; | ||
| } else { | ||
| const details = []; | ||
| if (data.wt > 0) details.push(`${data.wt.toFixed(1)} WT × 250€`); | ||
| if (data.we_fr > 0 || data.we_other > 0) { | ||
| const paid_we = we_total - 1.0; | ||
| details.push(`${paid_we.toFixed(1)} WE × 450€ (abzgl. 1,0 Abzug von ${deductedFrom})`); | ||
| } | ||
| note += `Erhält ${this.calculator.formatCurrency(bonus)}. ${details.join(', ')}.`; | ||
| } | ||
| employeeNotes.push(note); | ||
|
|
||
| // Build table row | ||
| html += ` | ||
| <tr> | ||
| <td class="employee-name">${safeName}</td>`; | ||
|
|
||
| // Days: Mo(1), Di(2), Mi(3), Do(4), Fr(5), Sa(6), So(0) | ||
| const dayOrder = [1, 2, 3, 4, 5, 6, 0]; | ||
|
|
||
| for (const dayIdx of dayOrder) { | ||
| const dayDuties = data.byWeekday[dayIdx]; | ||
| if (dayDuties.length === 0) { | ||
| html += `<td></td>`; | ||
| } else { | ||
| let cellContent = ''; | ||
| dayDuties.forEach(duty => { | ||
| const dateStr = duty.date.getDate() + '.'; | ||
| const shareStr = duty.share === 0.5 ? '½' : ''; | ||
| const amountStr = duty.isQual ? `${Math.round(duty.share * this.calculator.RATE_WEEKEND)}€` : `${Math.round(duty.share * this.calculator.RATE_NORMAL)}€`; | ||
| const tag = duty.isQual ? 'we-tag' : 'wt-tag'; | ||
| const isHoliday = this.holidayProvider.isHoliday(duty.date); | ||
| const isDayBefore = this.holidayProvider.isDayBeforeHoliday(duty.date); | ||
| const extraInfo = isHoliday ? ' (Feiertag)' : isDayBefore ? ' (Vor Feiertag)' : ''; | ||
|
|
||
| cellContent += `<span class="${tag}">${shareStr}X${extraInfo}</span><br><small>${amountStr}</small><br>`; | ||
| }); | ||
| html += `<td class="duty-cell">${cellContent}</td>`; | ||
| } | ||
| } | ||
|
|
||
| html += ` | ||
| <td class="${bonus > 0 ? 'bonus-amount' : 'no-bonus'}">${bonus > 0 ? this.calculator.formatCurrency(bonus) : '-'}</td> | ||
| </tr>`; | ||
| } | ||
|
|
||
| html += ` | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <div class="summary"> | ||
| <p class="total">Gesamtsumme: ${this.calculator.formatCurrency(totalBonus)}</p> | ||
| </div> | ||
|
|
||
| <h4>Erläuterungen zu den einzelnen Mitarbeitern:</h4> | ||
| `; | ||
|
|
||
| employeeNotes.forEach(note => { | ||
| html += `<div class="employee-note">${note}</div>\n`; | ||
| }); | ||
|
|
||
| html += ` | ||
| <div style="margin-top: 40px; padding-top: 20px; border-top: 1px solid #ddd;"> | ||
| <p><strong>Berechnungsregeln (Variante 2 - Streng):</strong></p> | ||
| <ul> | ||
| <li><strong>WE-Tage:</strong> Freitag, Samstag, Sonntag, Feiertage und Tage vor Feiertagen</li> | ||
| <li><strong>Schwelle:</strong> Mindestens 2,0 WE-Einheiten für Bonuszahlung erforderlich</li> | ||
| <li><strong>Vergütung bei Erreichen der Schwelle:</strong> | ||
| <ul> | ||
| <li>Werktage (WT): 250 € pro Einheit</li> | ||
| <li>WE-Tage: 450 € pro Einheit (abzüglich 1,0 Einheit Abzug, Freitag zuerst)</li> | ||
| </ul> | ||
| </li> | ||
| <li><strong>Unter Schwelle:</strong> Keine Bonuszahlung (weder WT noch WE)</li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <p style="margin-top: 30px; color: #666; font-size: 0.9em;"> | ||
| Erstellt am: ${new Date().toLocaleDateString('de-DE')} | Dienstplan NRW (Variante 2 - Streng) | ||
| </p> | ||
|
|
||
| </body> | ||
| </html>`; | ||
|
|
||
| // Open in new window | ||
| const reportWindow = window.open('', '_blank'); | ||
| if (reportWindow) { | ||
| reportWindow.document.write(html); | ||
| reportWindow.document.close(); | ||
| this.showToast('Bonus-Bericht wurde in einem neuen Fenster geöffnet.', 'success'); | ||
| } else { | ||
| this.showToast('Popup wurde blockiert. Bitte erlauben Sie Popups für diese Seite.', 'error'); | ||
| } | ||
| } |
There was a problem hiding this comment.
The exportBonusReport function contains approximately 300 lines of duplicated code between webapp/app.js and Dienstplan_Portable.html. Consider extracting the HTML template generation and styling into a shared module or template file to reduce maintenance burden. Changes to the report format currently need to be made in two places.
| } else { | ||
| let cellContent = ''; | ||
| dayDuties.forEach(duty => { | ||
| const dateStr = duty.date.getDate() + '.'; |
There was a problem hiding this comment.
The variable dateStr is defined but never used. It appears to have been intended for displaying dates in the duty cells but was not included in the final output. Consider removing this unused variable.
Suggested change
| const dateStr = duty.date.getDate() + '.'; |
| } else { | ||
| let cellContent = ''; | ||
| dayDuties.forEach(duty => { | ||
| const dateStr = duty.date.getDate() + '.'; |
There was a problem hiding this comment.
The variable dateStr is defined but never used. It appears to have been intended for displaying dates in the duty cells but was not included in the final output. Consider removing this unused variable.
Suggested change
| const dateStr = duty.date.getDate() + '.'; |
Comment on lines
+552
to
+553
| const weekdays = ['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag']; | ||
|
|
There was a problem hiding this comment.
The weekdays array is defined but never used in the exportBonusReport function. Consider removing this unused variable.
Suggested change
| const weekdays = ['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag']; | |
Owner
|
@copilot apply changes based on the comments in this thread |
Copilot stopped work on behalf of
Kenearos due to an error
December 12, 2025 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User requested output files formatted like formal bonus payment letters with weekday-based duty tables and per-employee explanations.
Changes
exportBonusReport()function in bothDienstplan_Portable.htmlandwebapp/app.jsReport Format
Screenshots
Bonus-Bericht Button
Generated Report
Original prompt
This section details on the original issue you should resolve
<issue_title>Ausgabe Datei</issue_title>
<issue_description>Kann eine der Dateien so aussehen? ungefähr?
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.