Open
Conversation
auto-assign
bot
requested review from
Mychecksdead,
edknotavailable,
exeokan,
mert577 and
recepsirin0
recepsirin0
requested changes
Aug 17, 2025
| AddressableLEDBufferView group = m_buffer.createView(startingIndex, endingIndex); //create new group(view) | ||
| m_groupList.put(groupID, group); | ||
| m_patternList.put(groupID, k_defaultPattern); //initially set the defaultPattern, so the runPattern command doesn't break | ||
| m_groupList[m_groupList.length] = group; //add the group to the groupList |
Member
There was a problem hiding this comment.
This causes a NullPointerException, because the array is never initialized with a size and cannot grow dynamically. Replace the arrays with ArrayList so you can add groups safely. same thing for the patternlist.
Collaborator
Author
There was a problem hiding this comment.
Yes I guess I thought about Python arrays while writing it, instead of ArrayList's I've initialized the arrays with the required size in the constructor class. Also coming in the next commit.
…izing arrays with required size beforehand and changed the name groupIndexes back to groupIDS as it caused confusion.
…functions properly in disabled mod. Works in simulation finally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brand new grouping system, uses 2 arrays instead of HashMaps and stores group details in Constants.java
closes #20