fix(web): use icon buttons for booking link actions - #3092
Merged
Conversation
Replace the Copy and Open booking page text controls with Phosphor icons, IconButton, and tooltips so the public-link row matches the event form action pattern. Fixes #3080 Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Split tooltip tests so each hover starts from a closed tooltip, and reuse IconButton's classes on the open-page anchor so the two controls stay visually identical. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings > Booking used text "Copy" / "Open booking page" controls for the public link. The rest of Compass uses icon buttons with tooltips.
This replaces those controls with Phosphor
Copy/ArrowSquareOuticons,IconButton+TooltipWrapperfor copy, and a tooltip-wrapped anchor for open (new tab). Aria-labels stayCopy booking linkandOpen booking page. Copied state still toasts viabooking-link-copiedand the tooltip/icon switch to Copied / Check for 2s.Fixes #3080
Simplicity
Matches the event form action row. Open stays an anchor.
iconButtonClassNameis shared so the open-page anchor andIconButtoncannot drift.Automated validation
bun run verifyPASS.Selected packages: web
Checks run: test:web, type-check, lint, knip, test:a11y, test:e2e
Checks skipped: (none)
Focused:
bun test:web packages/web/src/booking/BookingCopyLink.test.tsx(7 pass), including tooltip assertions for copy and open.Independent review
VERDICT: no confirmed findings
Accessible names, new-tab rel, and the copied toast are unchanged. Native link stays an anchor. Keyboard focus uses the existing IconButton focus ring.
Test plan
bun test:web packages/web/src/booking/BookingCopyLink.test.tsxbun run verify