fix(web): stop repeating email on destination calendar select - #3091
Merged
Conversation
Group destination options by account like the Settings default-calendar picker so Google primaries no longer render as email (email). Fixes #3082 Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
September 2, 2026 15:56
tyler-dane
deleted the
cursor/booking-destination-calendar-label-7a70
branch
September 2, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Google primary calendars report their display name as the account email. Booking settings then appended
(accountEmail)to every destination option, so primaries rendered asme@gmail.com (me@gmail.com).The destination select now groups writable calendars by account the same way Settings' Default Calendar picker does:
optgrouplabeled with the account email, option text is the calendar name only.Fixes #3082
Simplicity
Reuses
groupCalendarsByAccount, already used for blocking calendars in this section. No new label helper and no third inline format. Simplify pass: no extra commit.Automated validation
bun run verifyPASS.Selected packages: web
Checks run: test:web, type-check, lint, knip, test:a11y, test:e2e
Checks skipped: (none)
Focused:
bun test:web packages/web/src/booking/BookingSettingsSection.test.tsx(28 pass), including a whole-string assertion that a Google primary option ishost@example.com.Independent review
VERDICT: no confirmed findings
Native select, option values, and the empty-writable placeholder are unchanged. Account grouping matches the Default Calendar picker, including empty-group filtering. Keyboard and screen-reader names stay on the existing
Destination calendarcombobox.Test plan
bun test:web packages/web/src/booking/BookingSettingsSection.test.tsxbun run verify