fix(web): drop duplicate openToDate on the ends-on picker - #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3036 and #3043 each added an
openToDateon the Ends on datepicker. Main then failed type-check (TS17001) and lint (noDuplicateJsxProps). This keeps the #3036 behavior: with no until date, open at the event's month instead of today.Simplicity
One
openToDate. The remaining value isuntil ? undefined : miniDate.toDate()so a chosen end still drives the calendar viaselected.Automated validation
Independent review
Not a product change. Duplicate attribute was a merge leftover.
Test plan
bun run type-checkbun run lintbun test:web -- packages/web/src/views/Forms/EventForm/DateControlsSection/RecurrenceSection/RecurrenceSection.test.tsxNote
Low Risk
Lint/type fix only; recurrence picker behavior is unchanged aside from removing the invalid duplicate attribute.
Overview
Removes a duplicate
openToDateprop on the recurrence Ends onDatePickerthat came from overlapping merges and broke type-check and lint (noDuplicateJsxProps).The picker still has a single
openToDate={until ? undefined : miniDate.toDate()}so when no end date is set the calendar opens on the event’s month (viaminiDate) instead of today, while an existinguntilvalue continues to drive the view throughselected.Reviewed by Cursor Bugbot for commit 0878eb0. Bugbot is set up for automated code reviews on this repo. Configure here.