Skip to content

fix(web): drop duplicate openToDate on the ends-on picker - #3045

Merged
tyler-dane merged 1 commit into
mainfrom
fix/ends-on-duplicate-opentodate
Sep 1, 2026
Merged

fix(web): drop duplicate openToDate on the ends-on picker#3045
tyler-dane merged 1 commit into
mainfrom
fix/ends-on-duplicate-opentodate

Conversation

@cursor

@cursor cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

#3036 and #3043 each added an openToDate on the Ends on datepicker. Main then failed type-check (TS17001) and lint (noDuplicateJsxProps). This keeps the #3036 behavior: with no until date, open at the event's month instead of today.

Simplicity

One openToDate. The remaining value is until ? undefined : miniDate.toDate() so a chosen end still drives the calendar via selected.

Automated validation

bun run type-check  # pass
bun run lint        # 0 errors (pre-existing warnings only)
bun test:web -- packages/web/src/views/Forms/EventForm/DateControlsSection/RecurrenceSection/RecurrenceSection.test.tsx  # 6 pass

Independent review

Not a product change. Duplicate attribute was a merge leftover.

Test plan

  • bun run type-check
  • bun run lint
  • bun test:web -- packages/web/src/views/Forms/EventForm/DateControlsSection/RecurrenceSection/RecurrenceSection.test.tsx
Open in Web View Automation 

Note

Low Risk
Lint/type fix only; recurrence picker behavior is unchanged aside from removing the invalid duplicate attribute.

Overview
Removes a duplicate openToDate prop on the recurrence Ends on DatePicker that came from overlapping merges and broke type-check and lint (noDuplicateJsxProps).

The picker still has a single openToDate={until ? undefined : miniDate.toDate()} so when no end date is set the calendar opens on the event’s month (via miniDate) instead of today, while an existing until value continues to drive the view through selected.

Reviewed by Cursor Bugbot for commit 0878eb0. Bugbot is set up for automated code reviews on this repo. Configure here.

#3036 and #3043 each added an openToDate. Keep the event-month fallback
when no until is set so type-check and lint pass on main.

Co-authored-by: tyler <tyler@switchback.tech>
@tyler-dane
tyler-dane marked this pull request as ready for review September 1, 2026 01:45
@tyler-dane
tyler-dane merged commit 00f3e00 into main Sep 1, 2026
31 checks passed
@tyler-dane
tyler-dane deleted the fix/ends-on-duplicate-opentodate branch September 1, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants