Teach the clicked time's shortcut on empty grid clicks - #3042
Merged
Conversation
tyler-dane
marked this pull request as ready for review
September 1, 2026 00:12
Empty timed-grid clicks hit the hour-line overlay, so the hint never resolved a slot and fell back to "keyboard only". Detect those clicks and show the matching HHMM digits with a short create explanation. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Month-end evenings collapsed both stubbed slots onto 23:59 UTC, so the picker omitted the duplicate key and +30min crossed into the next day. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/grid-click-time-shortcut-dae0
branch
from
September 1, 2026 00:43
fc03806 to
d77df40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty clicks on the timed grid were falling back to a generic "keyboard only" hint. Those clicks hit the hour-line overlay, so the pointer hint never resolved a slot.
This change detects empty timed-grid clicks (hour rows and
#mainGrid) and shows the matching HHMM shortcut with a short explanation, for example "Type 1830 to create an event at 6:30 PM." Typing those digits still creates at the clicked instant.Simplicity
Reuse the existing pointer-hint and parked-draft path. The fix is to recognize the overlay that empty clicks actually hit, then keep teaching HHMM the same way annotated controls already teach
]or event-jump tokens.Test flake (booking only)
UTC month-end midnight made same-day sibling slots collapse onto 23:59. Booking unit and e2e helpers now step backward within the same UTC day when
+gapwould leave it.The RecurrenceSection until-picker walk-back landed on
mainin #3041, so this branch no longer carries that test change.Automated validation
pointer-action.test.ts,PointerHint.test.tsx)e2e/timed/mouse-inert.spec.ts4 pass, including the new empty-grid HHMM assertionbun run type-checkpassbun run lintpass (17 pre-existing warnings, none in this diff)1200/1830/0900and do not open a formPublicBookingPage.test.tsx26 passTest plan
bun test:web packages/web/src/shortcuts/keyboard-only/pointer-action.test.ts packages/web/src/components/PointerHint/PointerHint.test.tsxbun test:web packages/web/src/booking/PublicBookingPage.test.tsxbunx playwright test e2e/timed/mouse-inert.spec.tsbun run type-checkbun run lint