fix(web): calendar-colored event focus chrome - #2760
Merged
Conversation
Replace theme-accent rings and edge bars with the owning calendar's backgroundColor, drawn outside the card so short titles stay readable and each event only shows fill + calendar colors. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
GridDraft tests render without QueryClient; resolve focus color only from list parents that already own the lookup. Drafts fall back to --text for focus chrome. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Deduplicate the Timed/AllDay focus-visible outline class strings and keep edge-focus suppression in one place. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Fall back to --text when calendar backgroundColor fails 3:1 against the light page paper (local #fff and pale Google grays), so keyboard focus never vanishes in light theme. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event keyboard focus and start/end edge focus no longer use theme
--accent. They use the owning calendar’sbackgroundColor(when it has ≥3:1 contrast against the light page), drawn outside the card so short titles stay readable. Each event stays at two colors: fill + calendar (or--textwhen calendar color would vanish).Simplicity
eventFocusColor/eventFocusOutlineClass/eventEdgeFocusShadowhelpers so Timed and AllDay cards stay in syncGridDraft; drafts keep the--textfocus fallback without new provider requirements#fff, pale Google grays) instead of speculative theme-branchingAutomated validation
--textoutline, not accent blue; title readable/api/configrefused with no backend; no UI errorsbun run lint— no new errors (pre-existing warnings only)Independent review
Fresh read-only review found one confirmed High: local
#ffffffcalendar focus invisible on light theme. Fixed by falling back to--textwhen calendar color fails 3:1 against light page paper. No other confirmed findings.Test plan
bun test:webon EventCard, calendar-accent.util, calendarCardIdentity, GridDraftbun run lint