Remove in-app email opt-in; automate list sync outside the repo - #2759
Merged
Conversation
The 45-second-delayed subscribe modal was hard to time well and added config surface (EMAILER_SECRET, email: in compass.yaml, a Kit service, two API routes) that no self-hoster ever needs. New signups are now added to Kit by a scheduled job in compass-calendar-infra instead, so the app itself no longer knows the list exists. A tolerant `email:` schema entry keeps existing self-hosted compass.yaml files valid on upgrade. A one-line consent notice replaces the modal on the signup form. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Both were only ever used by the Kit email code removed in the prior commit; knip caught them as dead exports. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/user/email-updatesroutes,packages/backend/src/email/, the core email types + subscriber mapper,EMAILER_SECRET, and theKIT_API_SECRETbranch in the deploy workflow — no config noise left for self-hosters.email:key incompass.config.tsis kept as a tolerated, ignored placeholder (z.unknown().optional()) so existing self-hostedcompass.yamlfiles with anemail:block stay valid on upgrade.compass-calendar-infra(see KeepSoftwareSimple/compass-calendar-infra#81), which should merge and run successfully before this PR merges so no signup window goes unsynced.Test plan
bun run type-checkpassesbun run test:core(543/543),bun run test:backend(295/295) passbun run test:web(2165/2165; the 1 remaining failure is a pre-existingDayCalendarGridflake confirmed present onmaintoo, unrelated to this change)bun run lintpassesemailer/email-updates/ReleaseNotesPrompt/KIT_API_SECRET/Kit references🤖 Generated with Claude Code