refactor(web): remap event jump to s and hardcore to h - #2758
Merged
Conversation
Shift no longer previews jump chips or toggles Hardcore Mode, so Shift+Tab stops flashing shortcut labels. Use s for event jump and h for Hardcore; drop the shared Shift-tap gesture. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
mapToBackend applied the end clock time onto the start calendar day, so near-midnight create drafts (11:30 PM–12:30 AM) failed Zod validation and left the event form open — breaking the onboarding tour Save step. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Avoid near-midnight flakes where the next 15-minute Shift+Arrow move crosses day boundaries. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Yield to an armed e… sequence, and clear jump chips when entering Hardcore so Esc does not need two presses. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
August 11, 2026 23:37
Jump listeners register before RootShell, so unmatched printables were marking h prevented before Hardcore could toggle. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bare Shift no longer shows event-jump chips or toggles Hardcore Mode, so Tab / Shift+Tab stop flashing shortcut labels.
spreviews event-jump keycaps (Esc exits; week-viewsstill starts Sunday/Saturday prefixes while active)htoggles Hardcore Mode; yields to an armede… edit sequence; clears jump chips on enterSimplicity
Letter keys replace the Shift press/hold/double-tap state machine. Shared
isBareLetterKey, merged Hardcore keydown listeners, deleted deadsilenceOffhandoff path.Automated validation
e2e/timed/shift-hold-event-hints.spec.ts,e2e/timed/keyboard-only-mode.spec.ts,e2e/onboarding/interactive-tour.spec.ts: 8 passbun lint: clean (pre-existing warnings only)Independent review
Fixed confirmed findings:
hnow yields whilee… is armedOvernight save fix reviewed as correct.
Test plan
bun test:webon shortcut / datetime / day nudge / DayCalendarGrid filesbunx playwright test e2e/timed/shift-hold-event-hints.spec.ts e2e/timed/keyboard-only-mode.spec.ts e2e/onboarding/interactive-tour.spec.tsbun lints/h/ Shift+Tab at http://localhost:9080