fix(web): keep event color responsive during optimistic replace - #2744
Merged
Conversation
Discard grid drafts only after replace's optimistic cache write, matching create's onOptimisticApplied pattern, so color changes no longer flash the previous color while cancelQueries awaits. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Reuse patchGridDraftFields for color patches, drop colorHex before merge, and trim redundant test scaffolding. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing an event’s color (context menu or form save) discarded the grid draft before
replace’s async optimistic cache write finished, so the card briefly flashed the old color. This mirrors create’sonOptimisticAppliedteardown for replace.Changes
callbackson replace mutation variables soonOptimisticAppliedruns in the same task as the optimistic cache writeuseSetEventColor: paint the new color on the draft immediately, discard only viaonOptimisticApplieduseSaveEventFormedit path: close viaonOptimisticApplied(same as create)colorHexon optimistic replace when a slotcoloris written, so custom-hex events don’t keep the old fillTest plan
bun test:webonuseEventMutations,useSetEventColor, anduseSaveEventFormtests