fix(web): keep earlier recurrence instances when opening an occurrence - #2739
Merged
Conversation
Opening a later weekday occurrence rebuilt the RRULE with default INTERVAL=1, which falsely flipped preserve→series and hid earlier siblings. Treat INTERVAL=1 as equivalent to an omitted interval. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Apply draft updates in the regression so suppression stays null after mount, and strip INTERVAL=1 in either RRULE position. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a later weekday occurrence of a recurring series (e.g. Mon–Fri standup → click Thursday) made earlier instances disappear, even though the form still showed M–F selected.
Cause:
useRecurrencerebuilds the RRULE on open and re-emits defaultINTERVAL=1. Google-style rules omit that default, so the mount effect treated serialization drift as a real edit, flipped the draft frompreserve→series, suppressed sibling occurrences, and only showed forward draft previews from the clicked day.Fix: Extend
normalizeRecurrenceRuleto treat defaultINTERVAL=1as equivalent to an omitted interval (alongside the existingWKSTstrip), so open-for-edit stayspreserve.Simplicity
No separate simplify commit. The change is a one-line-class normalize extension plus a focused regression test. Sibling suppression and forward-only draft previews are left as-is — they are correct once a real recurrence edit exists.
Automated validation
Browser at http://localhost:9080 (anonymous IndexedDB):
Independent review
Fresh diff-first review: CLEAN after follow-ups.
Residual risk: other RRULE serialization drift beyond INTERVAL/WKST could still false-trigger a rewrite; not observed for the reported path.
Test plan