feat(web): place timed drafts with shift+arrow - #2735
Merged
Conversation
Shift+Arrow creates a keyboardPlace timed draft at the same default as c without opening the form, keeps grid focus for further repositioning, and Enter opens details. Focused saved events still nudge as before. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Assign a clientId in createTimedDraft so Shift+Arrow place-create can focus the draft card and Day Enter can open the live draft. Also open draft-only Day cards on pointer down like read-only cards. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Do not reseed when Shift+Arrow cannot move an existing draft, and do not place-create while a read-only (or any) grid card is focused. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Reuse Day openShortcutDraft for form-closed place, drop redundant Week draft guards, and focus place drafts via the known clientId. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
changed the title
tyler-dane
marked this pull request as ready for review
August 10, 2026 19:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a place-first timed draft flow via Shift+Arrow. Unfocused Shift+Arrow places a timed draft like c with the form closed; further Shift+Arrow repositions; Enter opens details; focused saved events still nudge. Guards prevent place-create over an existing draft or while any grid card (including read-only) is focused.
Simplicity
Day place-create reuses openShortcutDraft with openForm false. Redundant Week draft-existence guard removed in favor of the shared Shift+Arrow handler. Place drafts focus via the known clientId.
Automated validation
Browser at http://localhost:9080 Week view: place, reposition +15m, Enter opens form, focused saved-event nudge — all observed. bun test:web on touched suites, bun type-check, and bun lint passed.
Independent review
No confirmed findings after guard fixes. Earlier reseed-on-failed-move and read-only place-create issues were fixed before this ready state.
Test plan
Focused web suites for Week/Day shortcuts and DayCalendarGrid; bun type-check; bun lint; browser golden path above.