fix(web): stop the import overlay lying to established users, name the account - #2733
Merged
Merged
Conversation
…e account An established user's routine background catch-up and a brand-new account's first-ever import both collapse to the same aggregate "IMPORTING" product state. The week/day grid's empty-week overlay only checked that aggregate state, so a long-established user viewing a genuinely empty week during ordinary catch-up saw "Importing from Google..." as if this were a fresh connection - the exact misleading-state bug that getSidebarSyncStatus's lastHealthyAt distinction already exists to prevent, just not reused here. - Extracts that distinction into isFirstImportInProgress() and gates the grid overlay on it, so it only shows during an account's actual first import. - Softens the overlay's copy, which promised results "within a minute" unconditionally - true for a small calendar, false for a large one - to something that doesn't overpromise a timeline, and fixes a stray em-dash in the same string. - The sidebar's collapsed one-line status never named which account a reconnect problem belonged to (unlike Settings, where every account gets its own row). getSidebarSyncStatus's reconnect-required text now includes the account's email when one is available. Last of the fixes from a pre-launch sync stability + UX audit (first: #2728, second: #2729, third: #2731, fourth: #2732). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An established user's routine background catch-up and a brand-new account's first-ever import both collapse to the same aggregate
IMPORTINGproduct state. The week/day grid's empty-week overlay only checked that aggregate state, so a long-established user viewing a genuinely empty week during ordinary catch-up saw "Importing from Google..." as if this were a fresh connection — the exact misleading-state buggetSidebarSyncStatus'slastHealthyAtdistinction already exists to prevent, just not reused here.isFirstImportInProgress()and gates the grid overlay on it, so it only shows during an account's actual first import (Week'sGrid.tsxand Day'sDayCalendarGrid.tsx).getSidebarSyncStatus's reconnect-required text now includes the account's email when one is available; Settings' owngetGoogleSyncStatusis untouched since it doesn't need it.Last of the fixes from a pre-launch sync stability + UX audit (first: #2728, second: #2729, third: #2731, fourth: #2732).
Test plan
isFirstImportInProgress(6 cases covering the exact routine-catchup-vs-first-import distinction), reconnect-status text with/without an account emailbun run type-check— cleanbiome checkon all touched files — clean🤖 Generated with Claude Code