chore(scripts): retire repair-legacy-series-weekday tooling - #2536
Merged
Conversation
The one-off repair (PR #2535) has run successfully against prod: 37 legacy-migrated weekly series fixed across 9 tenants (all >=93% exception consensus, 35 of 37 at 100%), verified via direct DB reads and an idempotent rerun reporting 0 further changes. The population it targeted is closed - the current write/import paths are frame-consistent and cannot reproduce it - so the command has nothing left to do and no self-hosting relevance. Mirrors how the 2026-07-29 Sync-cutover one-off tooling (migrate-provider-state.ts, preseed-sync.ts, etc.) was deleted the day after confirmed use (commit 07816a8), rather than accumulating as permanent dead code. The full before/after data and methodology are preserved in PR #2535's description. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2535, per its own stated cleanup plan. The one-off
repair-legacy-series-weekdayCLI command has already run successfully against production: 37 legacy-migrated weekly series fixed across 9 tenants (all ≥93% exception consensus, 35 of 37 at 100%), verified by direct DB reads (both known-affected series now readBYDAY=SAand materialize exactly one occurrence per week) and an idempotent rerun in dry-run mode reportingfixed=0.The population it targeted is closed - the write/import paths were already confirmed frame-consistent (traced in #2535), so this defect cannot recur for new or future data. With nothing left to fix, the tool has no ongoing purpose and no self-hosting relevance (it repairs a hosted-product-only artifact of the 2026-07-29 Sync cutover).
This purely reverts the addition from #2535: deletes the command file, its subdirectory (implementation + tests), and its
cli.ts/cli.test.tsregistrations.git diff origin/mainon those two shared files is empty relative to their pre-#2535 state.Mirrors how the Sync-cutover's own one-off tooling (
migrate-provider-state.ts,preseed-sync.ts, etc.) was deleted the day after confirmed use (commit07816a841) rather than accumulating as permanent dead code. The full before/after data, methodology, and the founder's explicit go/no-go are preserved in #2535's description as the permanent record.Test plan
bun test:scripts- 24 pass (back to the pre-feat(scripts): repair legacy-migrated series with wrong-frame BYDAY #2535 baseline).bun run type-check- clean.biome check- clean.bun run knip- no dangling references to the removed module.git diff origin/main -- packages/scripts/src/cli.ts packages/scripts/src/cli.test.tsconfirmed empty pre-feat(scripts): repair legacy-migrated series with wrong-frame BYDAY #2535, i.e. this is a clean revert with nothing left behind.🤖 Generated with Claude Code