-
Notifications
You must be signed in to change notification settings - Fork 69
feat(web): make migrations storage agnostic #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2e7ae20
refactor(storage): implement StorageAdapter for task and event reposi…
tyler-dane 4f5c0aa
test(storage): add comprehensive tests for storage adapter and migrat…
tyler-dane e61bd4a
refactor(storage): update storage adapter imports and add new tests
tyler-dane 9879bcf
refactor(storage): remove deprecated db-init utility and associated t…
tyler-dane f95afdf
fix(storage): add bounds checking to reorder and retry support for in…
tyler-dane 31b78ad
refactor(storage): remove deprecated task-migration compatibility layer
tyler-dane d59e7c8
refactor(storage): remove deprecated CompassLocalDB and update tests …
tyler-dane ac8b2a6
refactor(storage): remove deprecated event storage utilities and upda…
tyler-dane 4e3a2c4
refactor(storage): migrate task storage utilities to use StorageAdapter
tyler-dane 3cb1509
feat(storage): add putTask method for single task management
tyler-dane 4f2e5d1
feat(tests): add end-to-end tests for task deletion and restoration
tyler-dane 998f9b9
feat(task-repository): implement saveTask method and update task mana…
tyler-dane 4c13e78
refactor(task-repository): consolidate task saving methods and update…
tyler-dane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { test } from "@playwright/test"; | ||
| import { | ||
| createTask, | ||
| deleteTaskWithKeyboard, | ||
| expectTaskMissing, | ||
| expectTaskSavedToIndexedDB, | ||
| expectTaskVisible, | ||
| prepareTaskPage, | ||
| restoreDeletedTaskFromUndoToast, | ||
| } from "../utils/task-test-utils"; | ||
|
|
||
| test.describe("Task Delete + Restore", () => { | ||
| test.skip( | ||
| ({ isMobile }) => isMobile, | ||
| "Tasks are not available in the current mobile experience.", | ||
| ); | ||
|
|
||
| test("should restore a deleted task from the undo toast", async ({ | ||
| page, | ||
| }) => { | ||
| await prepareTaskPage(page); | ||
|
|
||
| const taskTitle = `Delete Restore Task ${Date.now()}`; | ||
| await createTask(page, taskTitle); | ||
|
|
||
| await expectTaskVisible(page, taskTitle); | ||
| await expectTaskSavedToIndexedDB(page, taskTitle); | ||
|
|
||
| await deleteTaskWithKeyboard(page, taskTitle); | ||
| await expectTaskMissing(page, taskTitle); | ||
|
|
||
| await restoreDeletedTaskFromUndoToast(page); | ||
| await expectTaskVisible(page, taskTitle); | ||
| await expectTaskSavedToIndexedDB(page, taskTitle); | ||
|
|
||
| await page.reload(); | ||
| await expectTaskVisible(page, taskTitle, 10000); | ||
| await expectTaskSavedToIndexedDB(page, taskTitle); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.