refactor(onboarding): remove onboarding-related code and constants - #1455
Merged
Conversation
This commit removes the onboarding state management and related components, including hooks and constants, to simplify the codebase. The onboarding guide and its associated UI elements have been eliminated, streamlining the user experience and reducing complexity in the application. Additionally, references to onboarding in various components and tests have been cleaned up.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completely removes the onboarding system from the application, including all related state management, UI components, hooks, and utilities. The changes streamline the codebase by eliminating the guided onboarding experience, reducing complexity and removing unnecessary localStorage tracking.
Changes:
- Removed all onboarding-related components, hooks, utilities, types, and constants
- Cleaned up command palette components by removing "Re-do onboarding" menu item
- Updated router loaders to remove onboarding status checks
- Simplified auth flows by removing onboarding status fetching and state updates
- Removed onboarding-related storage keys and test utilities from e2e tests
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/views/Onboarding/utils/onboarding.util.ts | Deleted utility functions for onboarding view detection and welcome messages |
| packages/web/src/views/Onboarding/utils/onboarding.storage.util.ts | Deleted localStorage utility functions for onboarding progress tracking |
| packages/web/src/views/Onboarding/utils/onboarding.storage.util.test.ts | Deleted comprehensive test suite for storage utilities |
| packages/web/src/views/Onboarding/types/onboarding.guide.types.ts | Deleted TypeScript type definitions for onboarding guide system |
| packages/web/src/views/Onboarding/hooks/useStepDetection.ts | Deleted hook for detecting onboarding step completion |
| packages/web/src/views/Onboarding/hooks/useOnboardingProgress.ts | Deleted hook for tracking onboarding progress |
| packages/web/src/views/Onboarding/hooks/useGuideOverlayState.ts | Deleted hook for managing guide overlay display state |
| packages/web/src/views/Onboarding/hooks/useGuideOverlayState.test.ts | Deleted test suite for guide overlay state hook |
| packages/web/src/views/Onboarding/hooks/useCmdPaletteGuide.ts | Deleted main onboarding guide hook managing step progression |
| packages/web/src/views/Onboarding/hooks/useCmdPaletteGuide.test.ts | Deleted comprehensive test suite for command palette guide hook |
| packages/web/src/views/Onboarding/constants/onboarding.constants.ts | Deleted onboarding step configurations and constants |
| packages/web/src/views/Onboarding/components/OnboardingGuide.tsx | Deleted main onboarding guide component |
| packages/web/src/views/Onboarding/components/GuideSkipButton.tsx | Deleted skip button component for onboarding guide |
| packages/web/src/views/Onboarding/components/GuideProgressIndicator.tsx | Deleted progress indicator component showing step completion |
| packages/web/src/views/Onboarding/components/GuideInstructionContent.tsx | Deleted instruction content components for guide overlay |
| packages/web/src/views/Now/components/NowCmdPalette.tsx | Removed "Re-do onboarding" menu item and related imports |
| packages/web/src/views/Now/components/NowCmdPalette.test.tsx | Updated tests to remove assertions for onboarding menu item |
| packages/web/src/views/Day/hooks/onboarding/useCmdPaletteTutorial.ts | Deleted tutorial hook for command palette in Day view |
| packages/web/src/views/Day/hooks/onboarding/useCmdPaletteTutorial.test.tsx | Deleted test suite for command palette tutorial hook |
| packages/web/src/views/Day/components/DayCmdPalette.tsx | Removed "Re-do onboarding" menu item and related imports |
| packages/web/src/views/Day/components/DayCmdPalette.test.tsx | Updated tests to remove assertions for onboarding menu item |
| packages/web/src/views/CmdPalette/CmdPalette.tsx | Removed "Re-do onboarding" menu item and related imports |
| packages/web/src/routers/loaders.ts | Removed loadOnboardingStatus function and related imports |
| packages/web/src/routers/index.tsx | Changed loader from loadOnboardingStatus to loadAuthenticated |
| packages/web/src/components/AuthenticatedLayout/AuthenticatedLayout.tsx | Removed OnboardingGuide component from layout |
| packages/web/src/common/utils/auth/google-auth.util.ts | Removed onboarding status fetching and related types |
| packages/web/src/common/utils/auth/google-auth.util.test.ts | Removed tests for onboarding status fetching |
| packages/web/src/common/constants/storage.constants.ts | Removed ONBOARDING_PROGRESS storage key from schema and constants |
| packages/web/src/common/constants/onboarding.constants.ts | Deleted entire file containing onboarding progress schema and types |
| packages/web/src/auth/hooks/onboarding/useSkipOnboarding.ts | Deleted hook for managing onboarding skip state |
| packages/web/src/auth/hooks/onboarding/useIsSignupComplete.ts | Deleted hook for tracking signup completion status |
| packages/web/src/auth/hooks/onboarding/useIsSignupComplete.test.ts | Deleted test suite for signup completion hook |
| packages/web/src/auth/hooks/oauth/useGoogleAuth.ts | Removed onboarding-related hooks and status fetching from OAuth flow |
| packages/web/src/auth/hooks/oauth/useGoogleAuth.test.ts | Removed onboarding-related mock setup and test assertions |
| e2e/utils/test-constants.ts | Removed ONBOARDING_STATE constant used in e2e tests |
| e2e/utils/oauth-test-utils.ts | Removed onboarding state initialization from OAuth test setup |
| e2e/utils/event-test-utils.ts | Removed onboarding state initialization from calendar page setup |
This commit modifies the text displayed in the SessionExpiredToast component to provide a clearer message regarding the Google Calendar connection status. The test for the SessionExpiredToast has also been updated to reflect this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the onboarding state management and related components, including hooks and constants, to simplify the codebase. The onboarding guide and its associated UI elements have been eliminated, streamlining the user experience and reducing complexity in the application. Additionally, references to onboarding in various components and tests have been cleaned up.
Closes #1454