fix(core): hard-cap Presence Leaving to unmount ghost sheets#125
Draft
KealanAU wants to merge 5 commits into
Draft
fix(core): hard-cap Presence Leaving to unmount ghost sheets#125KealanAU wants to merge 5 commits into
KealanAU wants to merge 5 commits into
Conversation
…ut keyframe A leaving sheet could hang mounted and invisible, eating taps: any bindanimationstart cancels usePresence's 24-frame fallback, and a vue-lynx replace-all style patch during Leaving can kill the running animation without firing its end/cancel — Leaving never resolves. The same wipe can destroy the worklets' inline 'animation: none', restarting the .ui-leaving keyframe from fully open mid-close. - usePresence: un-cancellable MAX_LEAVING_FRAMES hard cap that forces Left (and clears the stuck animating flags) regardless of start events - SheetContentImpl: MT-driven closes now also gate the slide-out keyframe via a vyui-sheet__content--mt-close class applied in the same render as ui-leaving; the CSS gate pins the closed transform if inline styles are wiped
Deploying vyui with
|
| Latest commit: |
27fbcd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3018c6aa.vyui-2ow.pages.dev |
| Branch Preview URL: | https://fix-sheet-ghost-close.vyui-2ow.pages.dev |
The gate guaranteed a style patch in the render that applies ui-leaving, wiping the MT-written inline transition and letting the gate's pinned closed transform take over — every MT-driven close teleported instead of sliding. Revert SheetContentImpl to the plain close paths; the ghost is covered by usePresence's un-cancellable MAX_LEAVING_FRAMES cap alone.
… fix/sheet-ghost-close
KealanAU
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ghost sheet: a leaving panel could hang mounted and invisible, eating taps, because a
bindanimationstartcancels the Presence fallback and a vue-lynx replace-all style patch can then kill the animation without ever firing its end/cancel.usePresence: new un-cancellableMAX_LEAVING_FRAMES(60 ≈ 1s) hard cap — forcesLeftand clears the stuck animating flags even when a start event never resolves; stands down on state change or reopen@vyui/coreThe earlier
vyui-sheet__content--mt-closekeyframe gate is dropped: applying the gate class in the same render asui-leavingguaranteed a style patch that wiped the MT-written inline transition, so every MT-driven close teleported to the closed position instead of sliding.