Fixes to make this project compatible with modern Python versions (3.10+) and packages updates#100
Open
Leirbag-gabrieL wants to merge 9 commits into
Open
Fixes to make this project compatible with modern Python versions (3.10+) and packages updates#100Leirbag-gabrieL wants to merge 9 commits into
Leirbag-gabrieL wants to merge 9 commits into
Conversation
Fix for gym
…d, truncated, info). Add the ability to use truncation function and adapt the maximum number of steps per episode. Add gymnasium like pre-commit config, ran it and adapted the code. Deleted unused file aswell.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello, I wanted to use this repo to learn Q-learning and globally deep reinforcement learning. Unfortunately, right now when you pip install everything, some packages used (gym, and numpy) have received updates that broke the project. So I fixed them. It may break the current CI as I am maybe using some new Python features since I use Python 3.12.11.
For now, I've tested my code manually, it passes the tests and will soon add tests which targets changes I made.
This update is targeted in order to make changes for the Super Mario gym work properly, Kautenja/gym-super-mario-bros#137.
Here is a non-exhaustive list of changes I made :
Type of change
Please select all relevant options:
How Has This Been Tested?
Manually with super mario gym and using the test pipeline already made.
python3 -m unittest discover .a lotTest Configuration
Checklist