Skip to content

Avoid RangeInput constructor change events#1982

Open
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:fix-rangeinput-constructor-notify
Open

Avoid RangeInput constructor change events#1982
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:fix-rangeinput-constructor-notify

Conversation

@Tomeshwari-02

Copy link
Copy Markdown

Summary

  • Normalize RangeInput initial low/high values without calling onChange
  • Keep setRange notifications for post-construction changes
  • Add regression coverage for constructor initialization

Fixes #1972

Testing

  • Not run: Bun is not installed in this environment

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Tomeshwari-02, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 21121d12-001b-4d3b-9b8e-9875120ebf19

📥 Commits

Reviewing files that changed from the base of the PR and between 5f479e6 and d3fc6b3.

📒 Files selected for processing (2)
  • packages/ui/src/Slider.test.ts
  • packages/ui/src/Slider.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the needs-star PR author has not starred the repo. label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Hi @Tomeshwari-02 👋

Star this repo before your PR merges.

Why? GSSoC 2026 contributors who star get priority review and points credit. After you star, push any commit (or re-run this check). The needs-star label lifts automatically.

Thanks for your contribution to TermUI.

@github-actions github-actions Bot added area:ui @termuijs/ui type:testing +10 pts. Tests. labels Jul 3, 2026
@Tomeshwari-02 Tomeshwari-02 marked this pull request as ready for review July 3, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ui @termuijs/ui needs-star PR author has not starred the repo. type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] RangeInput calls onChange during construction when initial range is customized

1 participant