Fix: add _approx_equal_price_rounding to allow price in accepable range #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanho
force-pushed
the
fix/approx_equal_rounding
branch
from
a14bb40 to
175a726
Compare
vmartinv
reviewed
Dec 24, 2024
cgt_calc/main.py
Outdated
Comment on lines
95
to
94
| LOGGER.debug( | ||
| "Price error in calculated_price %.6f vs price_on_record %s", | ||
| calculated_price, | ||
| price_on_record, | ||
| ) |
There was a problem hiding this comment.
This logs the same information as the lines below, can you please remove it?
hermanho
force-pushed
the
fix/approx_equal_rounding
branch
2 times, most recently
from
e28dbd2 to
f8d03f5
Compare
hermanho
force-pushed
the
fix/approx_equal_rounding
branch
from
f8d03f5 to
582d3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: add _approx_equal_price_rounding to allow price in accepable range
Amount difference can be caused by rounding errors in the unit price.
Schwab rounds down the price to 4 decimal places so that the error in amount can be more than $0.01.
Fox example:
500 shares of FOO sold at $100.00016 with $1.23 fees.
"01/01/2024,"Sell","FOO","FOO","500","$100.0001","$1.23","$49,998.85"
calculated_amount = 500 * 100.0001 - 1.23 = 49998.82
amount_on_record = 49998.85 vs calculated_amount = 49998.82
In this PR change, the acceptable range of unit price is within $0.0001 when compare price on record and from retro calculation.