started main page #6
Conversation
client/src/app/app.component.html
Outdated
| </mat-select> | ||
| </mat-form-field> | ||
| </div> --> | ||
| <!----> |
There was a problem hiding this comment.
Remove all of the commented unnecessary code.
client/src/app/app.component.scss
Outdated
| position: absolute; | ||
| left:5%; | ||
| top:30%; | ||
| } |
There was a problem hiding this comment.
New line should be there at the end of each file.
client/src/app/app.component.ts
Outdated
| value: string; | ||
| viewValue: string; | ||
| } | ||
| export interface gend{ |
There was a problem hiding this comment.
Start the name of Interfaces with capital letter and variables with small like this, gender: Gender = []
client/src/app/app.component.ts
Outdated
| export class AppComponent { | ||
| title = 'client'; | ||
| spec: specialist[]=[ | ||
| {value:'1',viewValue:'Dermatologist'}, |
There was a problem hiding this comment.
Run ng lint command in the client folder and resolve all the errors and then commit.
There was a problem hiding this comment.
Also you should use nglint extension of vscode to check the errors. You can auto-indent the code in it using Ctrl + Shift + P then click on Beautify File option to auto indent everything, make sure to do it every file.
| {path:'mynav',component:MynavComponent}, | ||
| {path: 'dash',component: MydashComponent}, | ||
| {path:'table',component:MytableComponent} | ||
| ]; |
There was a problem hiding this comment.
Navbar and table are not something you'll route to, they'll always be on screen so remove their routes and change dash to dashboard in dashboard path.
| 23 error Or if that isn't available, you can get their info via: | ||
| 23 error npm owner ls client | ||
| 23 error There is likely additional logging output above. | ||
| 24 verbose exit [ 1, true ] |
There was a problem hiding this comment.
Never add debug log in your commits, always delete them before opening a PR.
2 participants
This adds a navigation bar and a links to sample dash-board and table.