Added navbar and footer #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish-ak
reviewed
Jan 16, 2019
|
|
||
| const appRoutes: Routes= [ | ||
| {path: '', component: MyDashComponent} | ||
| ] |
Member
There was a problem hiding this comment.
This should go in the AppRoutingModule, all components should be there in the app-routing.module.ts file as the path is the url you want for that component and component is the component you want to load whenever the corresponding path is accessed.
aashish-ak
requested changes
Jan 16, 2019
| MatSidenavModule, | ||
| MatIconModule, | ||
| MatListModule, | ||
| // RouterModule.forRoot(appRoutes), |
Member
There was a problem hiding this comment.
Remove this and add it in the app routing module file.
| @@ -1,5 +1,5 @@ | |||
| <!--The content below is only a placeholder and can be replaced.--> | |||
| <div style="text-align:center"> | |||
| <!-- <div style="text-align:center"> | |||
Member
There was a problem hiding this comment.
This Incomplete <!-- is the cause of your error as you haven't closed this comment, remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2 This PR adds a responsive side navigation bar with a toolbar and a footer(not in the screenshot provided). Dashboard schematic is generated but yet to be combined.
Implemented by using angular material schematics. Tutorial link:
https://www.youtube.com/watch?v=Bj2pYYoTs74&list=PLriqQSgHdESHOzOJwgUKeAgmqfc--gBUo&index=5