-
Notifications
You must be signed in to change notification settings - Fork 0
[App Update][Feature] Support for data-diff dimension for the better accuracy [DATA-15789] #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New dimensions and full diff functionality looks good 💯
- Low risk - no impact to
elt-run. Good to test it out.
https://kaligo.atlassian.net/browse/DATA-15789
Background
As mentioned in this thread, we need to have a mechanism in the diffa to increase the accuracy when we check diff.
Design
diff-dimensiondiff-dimensionsare specified, diffa will group by according to these columns. When select, it will cast those columns totextto ensure the consistent type for the simpliticycheck_datefull-diffmode is supported allowing to re-check the table from the very first beginning.Impact
Caveats
n/a
Testing
Working well in my local


full-diffmodeDocs
n/a
Author Checklist
For author: please complete the checklist before marking the PR as ready to review.
Github Bot Commands