Refactor the new module loading system to using pkgutil.iter_modules#786
Merged
Refactor the new module loading system to using pkgutil.iter_modules#786
Conversation
This subtly changes loading behavior. Previously, only name.py or name/__init__.py would be loaded. By iterating modules, this will also find compiled .so modules as as well as pre-compiled .pyc.
kageurufu
force-pushed
the
module_loading
branch
from
4d25813 to
3d55667
Compare
rogerlz
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This subtly changes loading behavior. Previously, only name.py or name/init.py would be loaded. By iterating modules, this will also find compiled .so modules as as well as pre-compiled .pyc. It also raises errors on plugin overrides early, instead of when the module is loaded.
This simplifies the code a fair bit, and makes plugins and overrides a bit more explicit
#705 has been rebased over this, and now works with the new system
Checklist