Conversation
Zeanon
force-pushed
the
feat/homing_samples
branch
from
0da0264 to
3120430
Compare
Zeanon
force-pushed
the
feat/homing_samples
branch
from
3120430 to
da0b5d7
Compare
You can now home with multiple samples, just like probes
Zeanon
force-pushed
the
feat/homing_samples
branch
from
da0b5d7 to
1923a69
Compare
| } | ||
|
|
||
| # Process samples if we have any | ||
| if len(distances) > 1: |
There was a problem hiding this comment.
If there's a single sample, is the toolhead already in the correct state here, since we are skipping all this? What about zero samples?
There was a problem hiding this comment.
single sample retains the original behaviour, so no need to process anything
0 samples is not possible logically, cause that would mean we don't home at all
klippy/extras/homing.py
Outdated
| gcode.run_script_from_command("M400") | ||
|
|
||
| if retries and hi.retry_gcode is not None: | ||
| gcode.respond_info("Executing retry_gcode") |
There was a problem hiding this comment.
Problably shouldn't be here? The retry_gcode can output info if it wishes to.
| # Perform second home | ||
| if (not hi.use_sensorless_homing or needs_rehome) and retract_dist: | ||
| if needs_rehome: | ||
| logging.info( |
There was a problem hiding this comment.
This probably needs to be less "debuggy"
There was a problem hiding this comment.
This came from the original code, I am happy to remove it but I wanted to keep as much of the original behaviour as possible
|
Not sure if Taking |
3 participants
Implement the same logic used for probing with multiple samples for homing as well.
Reasons:
Checklist