Skip to content

Lazarev#31

Open
TheAndrewLa wants to merge 28 commits into
Kakadu:masterfrom
TheAndrewLa:master
Open

Lazarev#31
TheAndrewLa wants to merge 28 commits into
Kakadu:masterfrom
TheAndrewLa:master

Conversation

@TheAndrewLa
Copy link
Copy Markdown

@TheAndrewLa TheAndrewLa commented Apr 18, 2026

  • Base task
  • Boolean type
  • Tuple types

upd:

  • Exceptions

Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/lib/interpreter.ml Outdated
Comment thread Lazarev/lib/interpreter.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@github-actions
Copy link
Copy Markdown

Документация и тестовое покрытие (96.93%) должны скоро появиться.

https://kakadu.github.io/fp25/docs/Lazarev

https://kakadu.github.io/fp25/cov/Lazarev

2026-04-21 11:02

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml
module Interpreter = Mini_ml_lib.Interpreter
module Parser = Mini_ml_lib.Parser

type opts = { mutable env : Interpreter.env }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

@github-actions
Copy link
Copy Markdown

Linter report from 2026-04-21 11:03, for mini language Lazarev

File "bin/REPL.ml", line 13, characters 14-43:
13 | type opts = { mutable env : Interpreter.env }
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Alert zanuda-linter: Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable `ref`erences and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant