C#_strange_Kuznetsov by f1i3g3 · Pull Request #28 · Kakadu/fp25

f1i3g3 · 2026-03-06T19:10:43Z

Added my version of C# language's subset (which is similar to miniML).
Supported:

Basic value types (ints, bools, chars, strings) + printing function
Basic expressions
Statements (if, for, while)
Parser & pretty printer (with cram & quickcheck tests)
Monadic typecheck
Monadic interpreter

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions

Zanuda-linter report

github-actions · 2026-03-07T08:14:30Z

+open Stdio
+
+type opts =
+  { mutable dump_parse_tree : bool


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-03-07T08:14:30Z

+type opts =
+  { mutable dump_parse_tree : bool
+  ; mutable file_path : string option
+  ; mutable eval : bool


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-03-07T08:14:30Z

+      match interpret_program ast with
+      | Ok (Some v) -> printf "Result: %s\n" (show_value v)
+      | Ok None -> printf "Result: void\n"
+      | Error _ -> failwith (sprintf "Interpretation error"))


Using failwith (or assert false) usually is a clue that a corner case is not being handled properly. To report errors we recommend using error monad instead. In princliple, these construction are OK for temporary work-in-progress code, but in release they should be eliminated

github-actions · 2026-03-07T08:14:30Z

+      | Ok (Some v) -> printf "Result: %s\n" (show_value v)
+      | Ok None -> printf "Result: void\n"
+      | Error _ -> failwith (sprintf "Interpretation error"))
+  | Error msg -> failwith (sprintf "Failed to parse file: %s" msg)


Using failwith (or assert false) usually is a clue that a corner case is not being handled properly. To report errors we recommend using error monad instead. In princliple, these construction are OK for temporary work-in-progress code, but in release they should be eliminated

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions · 2026-03-16T18:39:45Z

Документация и тестовое покрытие (81.07%) должны скоро появиться.

https://kakadu.github.io/fp25/docs/CSharpStrange_Kuznetsov

https://kakadu.github.io/fp25/cov/CSharpStrange_Kuznetsov

2026-03-16 21:39

github-actions

Zanuda-linter report

github-actions · 2026-03-16T18:40:46Z

+            | Error e -> failwith (sprintf "Interpretation error: %s" (show_error e)))
+         | None, Ok _ -> failwith "Interpretation error: Main method not found"
+         | _, Error e -> failwith (sprintf "Typecheck error: %s" (show_error e))))
+  | Error msg -> failwith (sprintf "Parser error: Failed to parse file: %s" msg)


Using failwith (or assert false) usually is a clue that a corner case is not being handled properly. To report errors we recommend using error monad instead. In princliple, these construction are OK for temporary work-in-progress code, but in release they should be eliminated

github-actions · 2026-03-16T18:40:46Z

+      gen_expr_no_assign env var_type >>= fun e -> return (EBinOp (OpAssign, EId id, e)))
+
+(* Binary operations *)
+and gen_binop_expr env expected_type =


Using function is recommended

github-actions · 2026-03-16T18:40:46Z

+  | _ -> gen_expr_no_assign env expected_type
+
+(* Binary operations without assignment *)
+and gen_binop_expr_no_assign env expected_type =


Using function is recommended

github-actions · 2026-03-16T18:40:46Z

+      ; (4, gen_funcall env TypeVoid >>= fun e -> return (SExpr e))
+      ; ( 2
+        , if
+            List.length (List.filter (fun (_, (_, ret)) -> ret <> TypeVoid) env.functions)


Bad measurement of a list (with non-negative size)
Between 'List.length
(List.filter (fun (, (, ret)) -> ret <> TypeVoid) env.functions)' and '
0'.

github-actions · 2026-03-16T18:40:46Z

+       with
+       | Ok expr' ->
+         let code_str' = expr_to_code_string expr' in
+         if code_str = code_str'


Executing 'if ... then true' smells bad

github-actions · 2026-03-16T18:40:46Z

+       with
+       | Ok prog' ->
+         let code_str' = program_to_code_string prog' in
+         if code_str = code_str'


Executing 'if ... then true' smells bad

github-actions · 2026-03-16T18:40:46Z

+         Angstrom.parse_string ~consume:Angstrom.Consume.All Parser.parse_ops code_str
+       with
+       | Ok expr' ->
+         if compare_expr_structure expr expr'


Executing 'if ... then true' smells bad

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions

Zanuda-linter report

github-actions · 2026-03-16T19:13:06Z

Linter report from 2026-03-16 22:13, for mini language CSharpStrange_Kuznetsov

f1i3g3 added 30 commits March 1, 2026 18:07

feat: current parser implementation

07651e8

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: quick fix

db1888f

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: class test fix

d9866cb

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: ast test fix

72d5527

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: quick parser tests fix

fe5b5bc

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

feat: added array declaration parser

a0e8ae5

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

test: added array parsing test

572711e

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: parser fixes; now factorial parsing should work

19527a8

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: test fix

cd7a8d5

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

feat: added pretty printer

287f5a0

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: quick fixes

bf2458d

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

feat: removed TODOs + unfinished features

cdaea8a

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: linter fix

9b2a38a

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

feat: added REPL with test

a0ceb7f

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: dune fix

9e6eb8d

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: formatting

9be8402

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: restored old version of ocamlformat

b0b3c9e

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

fix: formatting

4deaaa4

Signed-off-by: Dmitri <dmitrvlkuznetsov@gmail.com>

feat: added first version of typecheck

6045b80

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat: added REPL for parser + interpreter

cd45e7b

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: strings renaming

dc230bb

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat: add all what i have (still not finished)

63acde1

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: monad name fix

525272e

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(typecheck): many fixes, typecheck should compile now

c41d9a1

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(typecheck): some changes in tests

20e961f

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

docs: updated dune-project

2afff63

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: restored dune file

d589bd6

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat(tests): added QCheck tests

485b0ae

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(tests): tests fixes

a7af594

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(parser): parser fixes

b17558d

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions Bot reviewed Mar 7, 2026

View reviewed changes

f1i3g3 added 20 commits March 9, 2026 17:32

fix(tests): some changes in interpreter tests

3eec8c8

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(tests): updated cram test for factorial

bc31b04

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: major improvements for factorial test

d4e3fcc

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: deleted makefile

19afe9e

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat(tests): added fibonacci test

1dbceb5

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: attempt to calm zanuda

31130a9

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

refactor(parser): minor changes

5c65577

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat(tests): added more pp tests

60ce64e

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: typecheck tests renaming

0d15c0e

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(parser): some fixes

4e4ee20

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

feat(parser): added qcheck tests for parser & pp

e7ada6a

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: zanuda

91667db

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: added missing files

7a2c82f

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: small fix

7860cdd

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(tests): some quick test changes

3956488

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(REPL): REPL fix

3612985

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

docs: added docstrings for some ADTs

5f7f40c

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix(typecheck): break & continue

c715bb8

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

chore: removed TODOs

b376ef5

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

chore: renamed qcheck file

3194399

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions Bot reviewed Mar 16, 2026

View reviewed changes

github-actions Bot added TOO_MANY_LINTS and removed A_FEW_LINTS labels Mar 16, 2026

f1i3g3 added 2 commits March 16, 2026 21:58

fix: zanuda (removed lints)

50605c3

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

fix: quick fix

c34aa01

Signed-off-by: f1i3g3 <dmitrvlkuznetsov@gmail.com>

github-actions Bot reviewed Mar 16, 2026

View reviewed changes

github-actions Bot removed the TOO_MANY_LINTS label Mar 16, 2026

Conversation

f1i3g3 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 16, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

f1i3g3 commented Mar 6, 2026 •

edited

Loading