Tenyaeva by b08lsoai · Pull Request #18 · Kakadu/fp25

b08lsoai · 2026-01-18T14:20:15Z

implementation of the miniML interpreter

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions

Zanuda-linter report

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions

Zanuda-linter report

github-actions · 2026-01-19T14:28:36Z

@@ -0,0 +1,32 @@
+(** Copyright 2025, Tenyaeva Ekaterina *)


File 'Tenyaeva/tests/qcheck.ml' doesn't have corresponding .mli interface

github-actions · 2026-01-19T14:28:36Z

+open Tenyaeva_lib.Ast
+
+type options =
+  { mutable dump_parsetree : bool


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-01-19T14:28:36Z

+
+type options =
+  { mutable dump_parsetree : bool
+  ; mutable max_steps : int


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-01-19T14:28:36Z

+  let get st = st, Ok st
+  let put new_st _st = new_st, Ok ()
+  let fail e st = st, Error e
+  let run m st = m st


Eta reduction proposed. It's recommended to rewrite 'fun st -> m st' as
'm'

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions

Zanuda-linter report

github-actions · 2026-02-27T15:33:53Z

+open Tenyaeva_lib.Ast
+
+type options =
+  { mutable dump_parsetree : bool (* changed via command line argument *)


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions

Zanuda-linter report

github-actions · 2026-02-27T19:39:26Z

+
+type options =
+  { mutable dump_parsetree : bool (* changed via command line argument *)
+  ; mutable max_steps : int (* changed via command line argument *)


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions · 2026-03-03T17:02:35Z

Документация и тестовое покрытие (98.53%) должны скоро появиться.

https://kakadu.github.io/fp25/docs/Tenyaeva

https://kakadu.github.io/fp25/cov/Tenyaeva

2026-03-03 20:02

github-actions

Zanuda-linter report

github-actions · 2026-03-03T17:03:37Z

+open Tenyaeva_lib.Ast
+
+type options =
+  { mutable dump_parsetree : bool (* changed via command line argument *)


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-03-03T17:03:37Z

+
+type options =
+  { mutable dump_parsetree : bool (* changed via command line argument *)
+  ; mutable max_steps : int (* changed via command line argument *)


Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

github-actions · 2026-03-03T17:03:41Z

Linter report from 2026-03-03 20:03, for mini language Tenyaeva

File "bin/REPL.ml", lines 10-11, characters 4-3:
10 | ....mutable dump_parsetree : bool (* changed via command line argument *)
11 |   ;................................................................
Alert zanuda-linter: Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable `ref`erences and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.
File "bin/REPL.ml", line 11, characters 4-27:
11 |   ; mutable max_steps : int (* changed via command line argument *)
         ^^^^^^^^^^^^^^^^^^^^^^^
Alert zanuda-linter: Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable `ref`erences and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

b08lsoai added 30 commits November 24, 2025 23:24

chore: init project

1188969

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add AST

787720d

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add parser

3130fb7

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix (parser): typo in variable

4bcd00f

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: rewrite parse_expr_if using let*

196f85a

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add REPL.ml

46c3605

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add some parser tests

644ed20

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: remove unnecessary parameter in REPL

70a2f50

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat (parser): add pat_option & pat_constraint

ade5e6e

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat (parser): add match & function

ec75371

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add parser tests

c8f10bc

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add parser for fun

049cc43

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add parsers for option & arrow types

28df1da

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add type parser tests

eacf679

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add apply parser

19db6b3

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add operations parser

fa52d2d

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add some parser tests

a3c3e11

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add type_var parser

6dc1491

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add qcheck

a1fbf7a

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add qcheck generators

55972a1

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: comment cmp operations

df4f7bc

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add pretty printer

c9a8a66

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add qcheck runner

af8b412

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add qcheck.t

142bd02

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add state monad

ddf063d

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix : add the run signature

2faa040

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add interpreter

6ee419a

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

feat: add error & value pp

5eb357e

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix: correct the typo

0843874

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add interpreter tests

104e148

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

b08lsoai added 12 commits January 13, 2026 20:31

test: add more tests

9d8675d

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix: fix parsing priority

39baf74

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: remove unnecessary code

eb6c34e

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: correct some tests

b877d7b

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix: fix keyword parsing

bc7f463

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: correct tests

f9e1948

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: remove unnecessary code

0bd4637

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: rename error

277c4fe

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: clean up eval_value_binding

5ad59b5

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix: allow only functions in let rec

241db44

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: add & correct tests

5d9f938

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

chore: pin ppx_deriving_qcheck dependency

0e8cde1

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions Bot reviewed Jan 19, 2026

View reviewed changes

Comment thread Tenyaeva/tests/generators.ml

Comment thread Tenyaeva/bin/REPL.ml Outdated

Comment thread Tenyaeva/bin/REPL.ml Outdated

Comment thread Tenyaeva/lib/monad.ml Outdated

github-actions Bot added the A_FEW_LINTS label Jan 19, 2026

chore: add generators.mli

574f72e

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions Bot reviewed Jan 19, 2026

View reviewed changes

b08lsoai added 6 commits February 23, 2026 22:10

ref: zanuda-linter warnings

70cf4da

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: correct the typo

48d0e6f

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: replace deprecated generator functions

14bdcd9

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

fix: add parentheses to match

a743ab8

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

ref: replace Format. prefixes with local open

10d5a24

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

test: replace ppx_deriving_qcheck with manual gens

d6ac79d

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions Bot reviewed Feb 27, 2026

View reviewed changes

b08lsoai added 2 commits February 27, 2026 22:15

fix: disallow option patterns in let-binding

ff5a845

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

chore: remove ppx_deriving_qcheck dependency

c9913e3

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions Bot reviewed Feb 27, 2026

View reviewed changes

chore: add monad.mli & qcheck.mli

9f5ddbb

Signed-off-by: Tenyaeva Ekaterina <b08lsoai@gmail.com>

github-actions Bot reviewed Mar 3, 2026

View reviewed changes

Conversation

b08lsoai commented Jan 18, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant