feat: add shared bottom navigation shell#331
Open
sainath5001 wants to merge 1 commit into
Open
Conversation
Mount BottomNav via app/(app) route group so marketing / stays nav-free, wire orders list to detail routes, and raise ThemeToggle above the bar.
Contributor
|
Hello @sainath5001 could you upload some images or videos evidence of the correct functionality please? |
Author
Hi, @diegoTech14 Added evidence of the navigation shell added 3 photos. |
Author
|
sorry for large size screenshots but its working as per requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Issue
📖 Description
Adds a shared mobile-first bottom navigation bar and app layout chrome so users can move between existing screens.
✅ Changes made
frontend/components/ui/bottom-nav.tsx(lucide icons + Spanish labels,usePathnameactive state)app/(app)/layout.tsxso marketing/never shows the app nav/p2p/ordersand/transactionsunder(app); raised ThemeToggle above the fixed bar/p2p/orders/[id]; transactions back →/p2p/orders🖼️ Media (screenshots/videos)
/,/p2p/orders,/transactionsif you have them)📜 Additional Notes
app/(app)/layout.tsxinstead of hiding the nav by pathname in rootapp/layout.tsx, so marketing/never mountsBottomNav./trades/[id], detail-screen back buttons, and live/wallet+/chatpages. Nav links are present; destinations will work once those screen issues merge.