fix(assertions): add flags param to assert_not_contains_regex#99
Open
gastondana627 wants to merge 7 commits intoKaggle:cifrom
Open
fix(assertions): add flags param to assert_not_contains_regex#99gastondana627 wants to merge 7 commits intoKaggle:cifrom
gastondana627 wants to merge 7 commits intoKaggle:cifrom
Conversation
Adds a kaggle-bench CLI with two subcommands: - run: publish and run a local benchmark script on Kaggle - fork: pull an existing Kaggle benchmark notebook for local editing Extends the BenchmarkNotebookClient SDK from PR Kaggle#90 with a command-line interface so users can trigger benchmark runs directly from the terminal without writing Python boilerplate. Tests: 5 new unit tests covering help output, argument parsing, and correct delegation to BenchmarkNotebookClient.
Contributor
|
Thanks for the contribution. For independent changes, please base your branch on |
Collaborator
|
@gastondana627 wonder if you still want to work on this. The change should be straightforward after you rebase it on ci. |
Author
|
Thanks @dolaameng and @s-alexey, yes, I still want to get this in, however if you want to take care of it thats fine as well. It's a busy week on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
flagskeyword-only argument toassert_not_contains_regex, matching the same change made toassert_contains_regexin PR #82.Changes
*, flags=re.RegexFlag.NOFLAGparameter toassert_not_contains_regexflags=flagsinto there.search()callflagsargumentRelated
Addresses reviewer feedback from #82 where
dolaamengnoted: "We should changeassert_not_contains_regextoo."