Skip to content

Add video modality input support#95

Merged
mohami2000 merged 14 commits intocifrom
modality
Mar 31, 2026
Merged

Add video modality input support#95
mohami2000 merged 14 commits intocifrom
modality

Conversation

@mohami2000
Copy link
Copy Markdown
Contributor

@mohami2000 mohami2000 commented Mar 26, 2026

Added support for video inputs in the sdk and tests. I also tested this with a real api key and it worked great!
The changes on modelproxy side are already merged to support this.

I tested inputting videos and it worked!

design doc
BUG=b/496208368

@mohami2000 mohami2000 changed the title checkpoint Add video modality input support Mar 26, 2026
@dolaameng dolaameng requested a review from s-alexey March 26, 2026 22:27
@mohami2000 mohami2000 requested review from dolaameng and removed request for s-alexey March 27, 2026 14:42
Copy link
Copy Markdown
Contributor

@s-alexey s-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. However, they conflict significantly with #12. We should decide on the merge order.

@mohami2000
Copy link
Copy Markdown
Contributor Author

Changes look good. However, they conflict significantly with #12. We should decide on the merge order.

I think we should submit this first because it is needed to unblock some 1P partners :)

@mohami2000 mohami2000 requested a review from dolaameng March 30, 2026 19:55
Copy link
Copy Markdown
Collaborator

@dolaameng dolaameng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! LGTM. Will approve after we settle the user communication.

Also will wait for @s-alexey to take a final look with the refactoring code.

@mohami2000
Copy link
Copy Markdown
Contributor Author

Thanks for adding this feature! LGTM. Will approve after we settle the user communication.

Also will wait for @s-alexey to take a final look with the refactoring code.

Synced offline

@mohami2000 mohami2000 requested a review from dolaameng March 31, 2026 18:32
Copy link
Copy Markdown
Collaborator

@dolaameng dolaameng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock users requests. Please follow up on the plans to extend this. Thanks for adding the feature!

@mohami2000 mohami2000 merged commit 8d25031 into ci Mar 31, 2026
4 checks passed
@mohami2000 mohami2000 deleted the modality branch March 31, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants