Skip to content

test(tools): Add more golden tests for tools#114

Merged
dolaameng merged 3 commits intocifrom
dolaameng/golden_test
Apr 10, 2026
Merged

test(tools): Add more golden tests for tools#114
dolaameng merged 3 commits intocifrom
dolaameng/golden_test

Conversation

@dolaameng
Copy link
Copy Markdown
Collaborator

@dolaameng dolaameng commented Apr 1, 2026 •
edited
Loading

  1. Add golden tests for tools for coming PR Refactor LLM chats: separate streaming logic and enforce strict typing #12
  2. chore: reformatting

@dolaameng dolaameng changed the title chore: reformat and add golden tests test(tools): Add more golden tests for tools Apr 1, 2026
@dolaameng dolaameng requested a review from s-alexey April 1, 2026 21:17
@dolaameng
Copy link
Copy Markdown
Collaborator Author

dolaameng commented Apr 1, 2026 •
edited
Loading

@s-alexey I added some tests for tools. Feel free to apply this directly into your PR #12 (because some tests can only run after the refactoring), or approve this first, whatever is easier. Thanks

s-alexey
s-alexey approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@s-alexey s-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can merge this as is and refine it in the future if needed.

@dolaameng dolaameng merged commit 85a0abe into ci Apr 10, 2026
4 checks passed
@dolaameng dolaameng deleted the dolaameng/golden_test branch April 10, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-alexey s-alexey s-alexey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dolaameng @s-alexey