Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make versions tab non-interactive inside install flow #4302

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

HebaruSan
Copy link
Member

Problem

The Versions tab is available on the recommendations screen, but the checkboxes don't do anything, and the stability override dropdown throws an exception:

System.InvalidOperationException: This BackgroundWorker is currently busy and cannot run multiple tasks concurrently.
   at System.ComponentModel.BackgroundWorker.RunWorkerAsync(Object argument)
   at CKAN.GUI.Main.RefreshModList(Boolean allowAutoUpdate, Dictionary`2 oldModules)
   at CKAN.GUI.Main.StabilityToleranceConfig_Changed(String identifier, Nullable`1 relStat)
   at CKAN.Configuration.StabilityToleranceConfig.SetModStabilityTolerance(String identifier, Nullable`1 relStat)
   at CKAN.GUI.Versions.StabilityToleranceComboBox_SelectionChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectionChangeCommitted(EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectionChangeCommittedInternal(EventArgs e)
   at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)
   at System.Windows.Forms.ComboBox.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Cause

These interactive UI elements are only available because the rest of mod info is potentially useful in evaluating recommended mods to install. The dropdown needs to force an update of the mod list (in case changing it makes some mods newly installable or uninstallable), which requires using the progress screen, which is already doing something else while the install flow is active.

Changes

Now the Versions tab's checkboxes and dropdown are hidden on the recommendations screen.

Fixes #4290.

@HebaruSan HebaruSan added Bug Something is not working as intended GUI Issues affecting the interactive GUI labels Feb 7, 2025
@HebaruSan HebaruSan merged commit 8ec3b2c into KSP-CKAN:master Feb 7, 2025
2 checks passed
@HebaruSan HebaruSan deleted the fix/versions-read-only branch February 7, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting the stability override for a mod from the recommendations screen throws an exception
1 participant