-
Notifications
You must be signed in to change notification settings - Fork 255
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix appimage docker file generation, esp. make kdesrc-build run
We need to skip gpgme and build a kgraphviewer branch that's compatible with KF5. Then we also modernize the kdesrc-build usage in general, allowing us to set the tag option on the frameworks module-set directly. That means we can get rid of the custom kf5-frameworks-build-include copy and use the upstream metadata definition directly
- Loading branch information
Showing
3 changed files
with
11 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ ARG KDDockWidgets_VERSION=2.0 | |
ARG QCustomPlot_VERSION=2.1.1 | ||
ARG rust_demangler_VERSION=0.1.23 | ||
ARG d_demangler_VERSION=0.0.2 | ||
ARG KGraphViewer_VERSION=v2.4.3a | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
milianw
Author
Member
|
||
|
||
USER root | ||
|
||
|
@@ -98,26 +99,24 @@ RUN cd /opt && mkdir dlang && cd dlang && \ | |
deactivate && cd /opt && rm -Rf dlang && mv /usr/bin/gpg{~,} && mv /usr/bin/gpg2{~,} | ||
|
||
# kdesrc-build dependencies | ||
RUN yum install -y libcanberra-devel && \ | ||
RUN yum install -y libcanberra-devel gpgme-devel && \ | ||
cpan YAML::Syck JSON::XS YAML::XS | ||
|
||
# kde frameworks | ||
RUN cd /opt && git clone https://invent.kde.org/sdk/kdesrc-build.git | ||
COPY kdesrc-buildrc /opt/kdesrc-build/ | ||
COPY kf5-frameworks-build-include /opt/kdesrc-build/ | ||
RUN ldconfig && \ | ||
cd /opt/kdesrc-build && \ | ||
sed -i -e "s/FULL_NPROC/$(nproc)/g" -e "s/HALF_NPROC/$(($(nproc)/2))/g" kdesrc-buildrc && \ | ||
sed -i -e "s/%VERSION%/${KF5_VERSION}/g" kdesrc-buildrc && \ | ||
sed -i -e "s/%VERSION%/${KF5_VERSION}/g" kf5-frameworks-build-include && \ | ||
sed -i -e "s/FULL_NPROC/$(nproc)/g" \ | ||
-e "s/HALF_NPROC/$(($(nproc)/2))/g" -e "s/%VERSION%/${KF5_VERSION}/g" kdesrc-buildrc && \ | ||
./kdesrc-build --metadata-only && \ | ||
# fix compile error in kwallet | ||
./kdesrc-build --include-dependencies qca && \ | ||
./kdesrc-build --include-dependencies threadweaver kconfigwidgets kcoreaddons \ | ||
./kdesrc-build --ignore-modules=gpgme --include-dependencies threadweaver kconfigwidgets kcoreaddons \ | ||
kitemviews kitemmodels solid breeze-icons \ | ||
kwindowsystem knotifications kiconthemes karchive syntax-highlighting kio kparts && \ | ||
# without extra dependencies | ||
./kdesrc-build kgraphviewer && \ | ||
./kdesrc-build --revision ${KGraphViewer_VERSION} --no-include-dependencies kgraphviewer && \ | ||
cd /opt && rm -Rf kdesrc-build kde && ldconfig | ||
|
||
# kddockwidgets | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Should we have the feature #318 now also in the appimage?` If yes: where to find it, if no: how to enable that?
... and in any case: could you adjust the README to showcase this feature as well?