qt-build-utils: add QmlDir and QmlUri builders #1338
+451
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12927 12927
=========================================
Hits 12927 12927 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahayzen-kdab
force-pushed
the
qt-build-utils-add-qml-builders
branch
2 times, most recently
from
ac0fb93 to
ade9c8b
Compare
ahayzen-kdab
commented
Oct 3, 2025
| #![allow(clippy::too_many_arguments)] | ||
|
|
||
| mod builder; |
There was a problem hiding this comment.
maybe these are more generators than builders as they are creating strings rather than building anything 🤔
ahayzen-kdab
commented
Oct 3, 2025
| } | ||
|
|
||
| fn build(self) -> String { | ||
| // TODO: add slashes / sanitize |
There was a problem hiding this comment.
can use escape_default() for this
ahayzen-kdab
force-pushed
the
qt-build-utils-add-qml-builders
branch
from
ade9c8b to
4543212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.