Span inspector #1296
Span inspector #1296
Conversation
This highlights all output tokens that share the same span as the text cursor is hovering over.
Expansion erros are now shown directly in the output textfield.
- Fix incorrect calculation of target span - Fix false highlighting caused by Pretty Please code manipulation
- Prevents issues with special characters like '<' and '>' breaking the output HTML
These tokens are now ignored during parsing because prettyplease inserts them automatically in certain situations.
…fresh bug - Make output text area scrollable - Adjust text color to match the theme - Fix edge case where text change did not trigger refresh if cursor position stayed the same
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 75 75
Lines 12772 13038 +266
==========================================
+ Hits 12772 13038 +266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Before tests were failing due to an outdated Cargo.lock
- Tests were failing due to an outdated Cargo.lock
| }; | ||
| qt_thread | ||
| .queue(move |this| { | ||
| unsafe { this.output_document() }.set_html(&QString::from(output)) |
There was a problem hiding this comment.
If you do multiple subsequent edits to the input string, they all race to set their result as the output_string. If a later edit finishes faster, it will be overwritten by an edit that happened beforehand, leaving the app in an inconsistent state.
The easiest way to fix this is to add a request_token (just an i32) that is incremented every time a background thread is started.
Only the background thread with the matching request_token is then allowed to set its result.
There was a problem hiding this comment.
The THREAD_COUNT needs to be a member variable inside SpanInspector, not a global static.
Otherwise instantiating two span inspectors will misbehave.
It then also doesn't need to be atomic, but can just be a normal integer. Other than that it's correctly implemented. 👍
There was a problem hiding this comment.
@QuentinLeeWeber Once this is fixed, this PR is ready for approval.
- thread_count is no longer a static atomic type, so multiple span-inspectors can be used without interferrring their selfs
|
|
||
| let text = unsafe { Pin::new_unchecked(&mut *input.text_document()) }.to_plain_text(); | ||
|
|
||
| let thread_count = Arc::clone(&self.thread_count); |
There was a problem hiding this comment.
Again, the thread_count can just be a normal integer.
No Arc<Mutex<>> required.
It is only ever modified and read from the main thread, so there's no reason to make it shared.
2 participants
This PR introduces a tool called span-inspector that helps analyze and visualize the spans of tokens generated from the input to a cxx-qt-bridge macro.
Details