Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if MSVC Debug build uses wrong runtime #6

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Warn if MSVC Debug build uses wrong runtime #6

merged 1 commit into from
Feb 28, 2025

Conversation

LeonMatthesKDAB
Copy link
Collaborator

Check if CMAKE_MSVC_RUNTIME_LIBRARY != MultiThreadedDLL and emit a warning otherwise

ahayzen-kdab
ahayzen-kdab approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@LeonMatthesKDAB
Warn if MSVC Debug build uses wrong runtime
fdb2b6b 
Check if CMAKE_MSVC_RUNTIME_LIBRARY != MultiThreadedDLL and emit a
warning otherwise
@LeonMatthesKDAB LeonMatthesKDAB merged commit c8ebf90 into KDAB:main Feb 28, 2025
1 check passed
@ahayzen-kdab ahayzen-kdab added the backport-candidate Change which could be backported to the stable series label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
backport-candidate Change which could be backported to the stable series
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeonMatthesKDAB @ahayzen-kdab