Skip to content

Conversation

@Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Jun 28, 2025

When merged this pull request will:

  • Prevents airway collapse in awaked unit

This is a rare case and it is unclear whether this is a result of processing being accelerated by the latest 2.20 update.

But handleAirway would be executed by "treatmentAdvanced_RemoveAirwayItem" after (almost same timing with) a unit had woken up from unconscious, and this sometime causing obstruction in the airway of the awake unit then unconscious by low oxygen.
In handlePunking, the "isUnconscious" check exists for the loop, but handleAirway which has no loop processing so does not have check, so depending on the timing of execution the handleAirway, variable would be set to an incorrect value, and this is avoided by a double check.

Reported Issue: https://discord.com/channels/528955370941579265/1389725505019838566

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MiszczuZPolski MiszczuZPolski added this to the 3.1.3 milestone Jul 2, 2025
@MiszczuZPolski MiszczuZPolski added the kind/bug-fix Release Notes: **FIXED:** label Jul 2, 2025
@Apricot-ale
Copy link
Contributor Author

LG™

@BBlondyke
Copy link
Contributor

BBlondyke commented Nov 14, 2025

@Apricot-ale - Just wanted to see if this might still waiting merge or if there was a better fix found? We're occasionally seeing occlusions pop up from this scenario.

@Apricot-ale
Copy link
Contributor Author

Apricot-ale commented Nov 15, 2025

@Apricot-ale - Just wanted to see if this might still waiting merge or if there was a better fix found? We're occasionally seeing occlusions pop up from this scenario.

I wasn't sure what this scenario is (sorry for my poor English)

Yeah PR was indeed still waiting to be merge.
However, according to reports on Discord, trying this PR (test build) on MP, did not fix the bug completely.

And it's possible that the KAM REDUX fork by Cpl.Hardcore fixes it with even more revised code.
(In fact, REDUX contains similar code, with even more complex additions on top of it. If you can't wait for the 3.1.3 update, try that. However, it's not stable, so other KAM developers aren't responsible.)

I don't use REDUX, so I can't speak to details.
Try REDUX, or wait for the next update.

By the way, I no longer see the bug on my server using the latest Profiling Branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants