Conversion - Allows for Conversion of Player Patients to AI Patients #686

mazinskihenry · 2025-01-12T07:41:10Z

When merged this pull request will:

Allows for the conversion of player patients to AI patients, both automatically and by player choice
Modifies ACE State Machine to allow for AI patients to be treated as players
Allows for converted patients to be turned into either respawn tickets or Liberation supply

IMPORTANT

Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

…Role_Two

…njury) (#722) **When merged this pull request will:** - _Add Japanese translation for 3.1.0 Update for eye injury_ - _and small fix for Simple Chinese that messed up by AI translation_ ~~Do not merge before State Machine #713 and Conversion #686~~ This skipped to [another PR](#757)

LinkIsGrim · 2025-05-04T16:05:41Z

addons/statemachine/script_component.hpp

+    #define DEBUG_SETTINGS DEBUG_SETTINGS_STATEMACHINE
+#endif
+
+#include "\x\kat\addons\main\script_macros.hpp"


newline at EOF, everywhere.

addons/vitals/functions/fnc_handleUnitVitals.sqf

LinkIsGrim · 2025-05-04T16:07:07Z

addons/conversion/functions/fnc_libConversion.sqf

+params ["_patient"];
+
+private _storageAreas = (([getPos _patient] call KPLIB_fnc_getNearestFob) nearObjects (GRLIB_fob_range)) select {(_x getVariable ["KP_liberation_storage_type",-1]) == 0};
+private _crate = [KP_liberation_supplyCrate, GVAR(enableLiberationConversionGain), [(position _patient) select 0, (position _patient) select 1, 10000]] call KPLIB_fnc_createCrate;


what? no. raise an event and handle in a separate component or something. what is this spaghetti sauce

LinkIsGrim · 2025-05-04T16:20:56Z

addons/conversion/functions/fnc_libConversionDistance.sqf

This is even more tightly coupled to Liberation than I thought.

What the fuck? Does this even work without Liberation? Why are you allergic to event handlers?

It does work without liberation, it is just that liberation is one of the biggest use cases and the hardest to build out for, so everything is written around liberation

Then raise events and handle them in Liberation code instead of coupling a medical mod's code to the workings of a CTI gamemode that doesn't have a defined API and barely gets maintained.}

What happens if Liberation completely does away with the concept of FOBs and becomes a laser tag simulator tomorrow?

Then the "GRLIB_fob_range" variable becomes -1, libConversionDistance returns as true, and everything else can run as is

Cplhardcore

My two cents follow what Grim said. i genuinely don't get why this is so tightly tied to liberation, especially when it is actively breaking this PR when not being run

IMO, ditch it, and if you want it tied into liberation, use events, don't tie it directly

Cplhardcore · 2025-07-13T09:55:37Z

addons/conversion/XEH_postInit.sqf

+
+[QGVAR(convertCasualty), {
+    private _type = typeOf player; 
+    private _group = createGroup [(side player), true]; 


Suggested change

private _group = createGroup [(side player), true];

private _group = createGroup [(side group player), true];

side player on an uncon player returns CIV, not the original side

Cplhardcore · 2025-07-13T09:56:10Z

addons/conversion/XEH_postInit.sqf

+
+[QGVAR(unitTransfer), {
+    params ["_previousUnit"];
+    private _group2 = createGroup [(side _previousUnit), true]; 


Suggested change

private _group2 = createGroup [(side _previousUnit), true];

private _group2 = createGroup [(side group _previousUnit), true];

Same as above

Cplhardcore · 2025-07-13T09:59:41Z

addons/conversion/functions/fnc_manualConversionCondition.sqf

+
+if !(IS_UNCONSCIOUS(_patient)) exitWith { false };
+if !(GVAR(allowManualConversion)) exitWith { false };
+


Add a check for if they are already are converted

Cplhardcore · 2025-07-13T10:00:45Z

addons/conversion/functions/fnc_ticketConversion.sqf

+
+params ["_patient"];
+
+[(side _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;


Suggested change

[(side _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;

[(side group _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;

Cplhardcore · 2025-07-13T10:01:55Z

addons/main/script_macros.hpp

 #define GET_BLOODPRESSURE_CHANGE(unit) (unit getVariable [VAR_BLOODPRESSURE_CHANGE, [0,0]])

+// Conversion
+#define UNIT_CONVERT                   QEGVAR(conversion,convert)


Suggested change

#define UNIT_CONVERT QEGVAR(conversion,convert)

#define UNIT_CONVERT QEGVAR(conversion,currentConverted)

Cplhardcore · 2025-07-13T10:05:49Z

addons/vitals/functions/fnc_hasStableVitals.sqf

 if (_unit getVariable [QEGVAR(surgery,sedated), false]) exitWith { false };
 if (_unit getVariable [QEGVAR(surgery,reboa), false]) exitWith { false };

+if (_unit getVariable [QEGVAR(conversion,convert), false]) exitWith { false };


Why is this even here? this breaks a bunch of things, not to mention external mods that use this
If you want to prevent units from waking up when converted, just check the variable inside those functions, dont do it in here

... this is the hasStableVitals function, this is the only place where waking up is checked. If waking isn't blocked here, then it isn't blocked

There are three other places, in reorientation, carbonate, and setUncon

Which all check hasStableVitals to see if they can work

i am aware, but other units and mods use hasStableVitals for checks, and putting something that explicitly breaks that doesn't make sense to me

But this doesnt break it. That is like saying that the surgery stuff shouldn't be in hasStableVitals because it breaks it for other units and mods. If conversion is disabled, then its fine and the function runs as normal.

If conversion is enabled, and a casualty is converted, then hasStableVitals will return false, even if the unit is completely fine

Which is exactly how it should work, converted casualties are just there to either recover tickets or Lib supply, they aren't meant to be woken back up again

Cplhardcore · 2025-07-13T10:07:04Z

addons/conversion/CfgVehicles.hpp

I don't get why these are ace actions, just make them medical menu actions like manual conversion.

Cplhardcore · 2025-07-13T10:12:42Z

addons/conversion/ACE_Medical_Treatment_Actions.hpp

+        treatmentLocations = QGVAR(manualConversionLocation);
+        treatmentTime = QGVAR(manualConversionTime);
+        allowedSelections[] = {"All"};
+        items[] = {""};


Suggested change

items[] = {""};

items[] = {};

category = "advanced";

allowSelfTreatment = 0;

};

};

mazinskihenry · 2025-07-13T15:29:15Z

My two cents follow what Grim said. i genuinely don't get why this is so tightly tied to liberation, especially when it is actively breaking this PR when not being run

IMO, ditch it, and if you want it tied into liberation, use events, don't tie it directly

This is tied to Liberation because its one of the most used mission frameworks in the A3 community. The issue currently is a locality problem, not that it breaks when Liberation isnt loaded.

Cplhardcore · 2025-07-15T09:45:39Z

addons/conversion/functions/fnc_manualConversion.sqf

+
+ params ["_medic", "_patient"];
+
+[QGVAR(convertCasualty), _patient] call CBA_fnc_localEvent;


Suggested change

[QGVAR(convertCasualty), _patient] call CBA_fnc_localEvent;

[QGVAR(convertCasualty), [_patient], _patient] call CBA_fnc_targetEvent;

If its local, it will cause the medic to die

mazinskihenry added 12 commits January 11, 2025 01:36

Start

b312e6b

Working?

2360b79

Pulling hairs

0bf1fef

Ticket/Lib Supply Conversion

aa72614

Extension

010fd88

Diag_log remove

f89b676

Mechanics

234172d

Update stringtable.xml

8dd8144

Headers

6f2b196

Update fnc_handleUnitVitals.sqf

f411965

Errors

a0d0d73

Merge branch 'Role_Two' of https://github.com/mazinskihenry/KAM into …

218b85e

…Role_Two

mazinskihenry added enhancement New feature or request kind/enhancement Release Notes: **IMPROVED:** labels Jan 12, 2025

Update stringtable.xml

4fb4d00

MiszczuZPolski added kind/feature Release Notes: **ADDED:** and removed enhancement New feature or request labels Jan 12, 2025

mazinskihenry added 2 commits January 12, 2025 09:33

Update fnc_handleUnitVitals.sqf

c99d9f1

One Life Conversion

5d8768e

mazinskihenry added this to the Ongoing milestone Jan 12, 2025

mazinskihenry added 8 commits January 12, 2025 16:27

Redo Config

c2bdda8

Its broken again

846f3fc

Update fnc_KATConditionExecutionDeath.sqf

ce56b12

Working again

eeccf2e

Add option to disable text

4375982

Add distance for libConversion and one life options

5f143f8

Delete fnc_spectatorRespawn.sqf

e59b2d2

Update XEH_PREP.hpp

7c7ed1d

mazinskihenry mentioned this pull request Jan 15, 2025

Statemachine - Adds Statemachine #677

Closed

Update fnc_manualConversionCondition.sqf

30950d3

mazinskihenry restored the Role_Two branch March 12, 2025 03:01

mazinskihenry reopened this Mar 12, 2025

mazinskihenry and others added 11 commits April 1, 2025 14:20

Update XEH_postInit.sqf

cb18c68

Merge branch 'dev-Tomcat' into pr/686

2fd12c6

use api

c02ce5a

use macros

84144b7

move settings to separate file, fix casing

16f0b80

Merge branch 'dev-Tomcat' into pr/686

be8e2ab

sort

a7cb839

Update stringtable.xml

826a60c

Update stringtable.xml

07369ed

Update stringtable.xml

030b2ed

Update initSettings.inc.sqf

2aa8d70

Apricot-ale mentioned this pull request Apr 8, 2025

Translation - Improve Japanese (3.1.X, Conversion/Imp.PTX) #757

Closed

mazinskihenry added 3 commits April 24, 2025 11:18

Update fnc_manualConversionCondition.sqf

ee3cb70

Update fnc_manualConversionCondition.sqf

406273c

Update fnc_manualConversionCondition.sqf

4b55167

LinkIsGrim reviewed May 4, 2025

View reviewed changes

addons/vitals/functions/fnc_handleUnitVitals.sqf Show resolved Hide resolved

LinkIsGrim reviewed May 4, 2025

View reviewed changes

Update fnc_handleUnitVitals.sqf

981e940

MiszczuZPolski modified the milestones: 3.1.0, 3.1.1 Jun 5, 2025

Cplhardcore suggested changes Jul 13, 2025

View reviewed changes

Cplhardcore reviewed Jul 15, 2025

View reviewed changes

MiszczuZPolski modified the milestones: 3.1.3, Ongoing Dec 18, 2025

	private _group = createGroup [(side player), true];
	private _group = createGroup [(side group player), true];

	private _group2 = createGroup [(side _previousUnit), true];
	private _group2 = createGroup [(side group _previousUnit), true];


		if !(IS_UNCONSCIOUS(_patient)) exitWith { false };
		if !(GVAR(allowManualConversion)) exitWith { false };


		params ["_patient"];

		[(side _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;

	[(side _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;
	[(side group _patient), GVAR(ticketConversionGain)] call BIS_fnc_respawnTickets;

	#define UNIT_CONVERT QEGVAR(conversion,convert)
	#define UNIT_CONVERT QEGVAR(conversion,currentConverted)

-        items[] = {""};
+        items[] = {};
+        category = "advanced";
+        allowSelfTreatment = 0;
+    };
+};


		params ["_medic", "_patient"];

		[QGVAR(convertCasualty), _patient] call CBA_fnc_localEvent; No newline at end of file

	[QGVAR(convertCasualty), _patient] call CBA_fnc_localEvent;
	[QGVAR(convertCasualty), [_patient], _patient] call CBA_fnc_targetEvent;

Conversion - Allows for Conversion of Player Patients to AI Patients #686

Are you sure you want to change the base?

Conversion - Allows for Conversion of Player Patients to AI Patients #686

Uh oh!

Conversation

mazinskihenry commented Jan 12, 2025

IMPORTANT

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mazinskihenry May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LinkIsGrim May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mazinskihenry May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Cplhardcore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mazinskihenry commented Jul 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mazinskihenry May 4, 2025 •

edited

Loading

LinkIsGrim May 4, 2025 •

edited

Loading

mazinskihenry May 4, 2025 •

edited

Loading