Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version extraction from filename for ex2300 firmware (fixes #694) #695

Conversation

Yannik
Copy link
Contributor

@Yannik Yannik commented Oct 1, 2024

This fixes #694.

@chidanandpujar
Copy link
Collaborator

Hi @Yannik
Thanks for submitting the pull request.
we will review the fix and update.

Thanks
Chidanand

@chidanandpujar chidanandpujar self-requested a review November 11, 2024 12:25
Copy link
Collaborator

@chidanandpujar chidanandpujar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chidanandpujar chidanandpujar merged commit 594e805 into Juniper:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

junos.device.software not parsing version from filename correctly for EX2300
2 participants