Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ping packet loss in float #686

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

chidanandpujar
Copy link
Collaborator

when ping packet loss value is in float then module fails with following error
ValueError: invalid literal for int() with base 10: '33.3333'

Added code to read the value as float and round of the value to nearest integer.

@chidanandpujar
Copy link
Collaborator Author

Please find the test results:

ansible-playbook pb.juniper_junos_pmtud.yml 


PLAY [Test juniper.device.pmtud module] ***********************************************************************************************************************************

TASK [TEST 1 - Check path MTU to host DNS] ********************************************************************************************************************************
ok: [localconnectiontestcases]

TASK [Check TEST 1] *******************************************************************************************************************************************************
ok: [localconnectiontestcases] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [TEST 2 - Configure and check inet.mtu to host DNS] ******************************************************************************************************************
ok: [localconnectiontestcases]

TASK [Check TEST 2] *******************************************************************************************************************************************************
ok: [localconnectiontestcases] => {
    "changed": false,
    "msg": "All assertions passed"
}

PLAY RECAP ****************************************************************************************************************************************************************
localconnectiontestcases   : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   



# ansible-playbook pb.juniper_junos_pmtud.yml 


PLAY [Test juniper.device.pmtud module] ***********************************************************************************************************************************

TASK [TEST 1 - Check path MTU to host DNS] ********************************************************************************************************************************
ok: [pyezconnectiontestcases]

TASK [Check TEST 1] *******************************************************************************************************************************************************
ok: [pyezconnectiontestcases] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [TEST 2 - Configure and check inet.mtu to host DNS] ******************************************************************************************************************
ok: [pyezconnectiontestcases]

TASK [Check TEST 2] *******************************************************************************************************************************************************
ok: [pyezconnectiontestcases] => {
    "changed": false,
    "msg": "All assertions passed"
}

PLAY RECAP ****************************************************************************************************************************************************************
pyezconnectiontestcases    : ok=4    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

@chidanandpujar chidanandpujar merged commit fab695d into Juniper:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants