Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #672 to handle float values #673

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

chidanandpujar
Copy link
Collaborator

@chidanandpujar chidanandpujar commented Jun 24, 2024

for ping command response, packet loss values might of type float values, so added the code to read the value in float and round of it to nearest integer value before comparing it with acceptable_packet_loss.

@chidanandpujar
Copy link
Collaborator Author

TASK [Test reachability to device using do-not-fragment and rapid] ********************************************************************************************************
ok: [10.220.24.28]

TASK [Print the full test response] ***************************************************************************************************************************************
ok: [10.220.24.28] => 
  test_ping:
    acceptable_percent_loss: '50'
    changed: false
    count: '3'
    dest: x.x.x.x
    dest_ip: x.x.x.x
    do_not_fragment: false
    failed: false
    host: x.x.x.x
    interface: null
    msg: Loss 33.3333%, (Sent 3 | Received 2)
    packet_loss: '33.3333'
    packets_received: '2'
    packets_sent: '3'
    rapid: true
    routing_instance: null
    rtt_average: '104'
    rtt_maximum: '175'
    rtt_minimum: '33'
    rtt_stddev: '71'
    size: '64'
    source: null
    source_ip: null
    timeout: '120'
    ttl: null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants